From: "H. Peter Anvin" <hpa@zytor.com>
To: Jacek Luczak <difrost.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Comma at end of enum lists
Date: Sat, 29 Mar 2008 10:20:38 -0700 [thread overview]
Message-ID: <47EE7A66.30905@zytor.com> (raw)
In-Reply-To: <47EE75A0.8070705@gmail.com>
Jacek Luczak wrote:
> Hi All,
>
> I've found that in many enum lists, there's a comma at the end, e.g.
> (arch/x86/kernel/early_printk.c):
>
> enum {
> MAGIC1 = 0xBACCD00A,
> MAGIC2 = 0xCA110000,
> XOPEN = 5,
> XWRITE = 4,
> };
>
> Just out of curiosity, is there any particular reason here (no word in
> CodingStyle about that).
>
Yes, it's so you can add a line without affecting the line before it,
making a one-line patch into a two-line patch that's more likely to
conflict.
-hpa
next prev parent reply other threads:[~2008-03-29 17:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 17:00 Comma at end of enum lists Jacek Luczak
2008-03-29 17:19 ` Mikael Pettersson
2008-03-29 17:22 ` Jacek Luczak
2008-03-29 18:13 ` Andreas Schwab
2008-03-29 18:24 ` Jan Engelhardt
2008-03-29 18:47 ` Andreas Schwab
2008-03-29 17:20 ` H. Peter Anvin [this message]
2008-03-29 17:25 ` Al Viro
2008-03-29 17:26 ` Jacek Luczak
2008-03-29 17:56 ` Al Viro
2008-03-29 17:57 ` H. Peter Anvin
2008-03-29 17:28 ` H. Peter Anvin
2008-03-29 17:42 ` Jan Engelhardt
2008-03-29 17:52 ` Al Viro
2008-03-29 17:54 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EE7A66.30905@zytor.com \
--to=hpa@zytor.com \
--cc=difrost.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox