From: Jiri Slaby <jirislaby@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Drop an empty byteorder/generic.h from being exported to userspace.
Date: Wed, 02 Apr 2008 13:01:32 +0200 [thread overview]
Message-ID: <47F3678C.9000000@gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0804020656170.13637@localhost.localdomain>
On 04/02/2008 01:00 PM, Robert P. J. Day wrote:
> On Wed, 2 Apr 2008, Jiri Slaby wrote:
>
>> On 04/02/2008 03:38 AM, Robert P. J. Day wrote:
>>> Since the entire meaningful contents of generic.h is wrapped by the
>>> __KERNEL__ test, drop it from being passed to userspace, and remove
>>> the now superfluous __KERNEL__ test.
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>
>>> ---
>>>
>>> is there some value in allowing an effectively empty header file to
>>> be exported to userspace?
>> Not breaking the userspace? The file is included in non-__KERNEL__
>> sections from byteorder/*_endian.h.
>
> ok ... and the value of including a completely empty header file is
> ... ?
No value, you should just move those includes into the __KERNEL__ part.
next prev parent reply other threads:[~2008-04-02 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 1:38 [PATCH] Drop an empty byteorder/generic.h from being exported to userspace Robert P. J. Day
2008-04-02 10:20 ` Jiri Slaby
2008-04-02 11:00 ` Robert P. J. Day
2008-04-02 11:01 ` Jiri Slaby [this message]
2008-04-02 11:02 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F3678C.9000000@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox