Re: [patch 3/3] ata: SWNCQ should be enabled by default

Re: [patch 3/3] ata: SWNCQ should be enabled by default

[Jeff Garzik]

Kuan Luo wrote:
> Robert wrote:
>> -Hotplug/hot-unplug fails to work properly, hotplug interrupts not 
>> raised (seemingly only on certain boards/configurations as I can't 
>> duplicate this problem). 
>> http://bugzilla.kernel.org/show_bug.cgi?id=8421
>>
> I occasionly encountered this problem in one port under certain system,
> but didn't see this issue under other systems in the same mainboard.
> After adding the operation of manually clearing the added/removed
> interrupt bit in NV_INT_STATUS_CK804 register 
> in nv_adma_interrupt function,  i saw some improvement.  
> 
> The key problem is that no one who knows this controller comes to help
> to solve these issue.
> Given this disadvantage, i think disabling it maybe is a good choice.
> I don't know whether we need to continue to provide patch for adma after
> disabling adma function.

Based on all these discussions and experiences, I just checked in the 
following commit, setting adma_enabled to zero:


     [libata] sata_nv: disable ADMA by default

     Continues to have open issues, and engineering support is extremely
	 difficult to come by, according to fellow NVIDIA engineers.

     Signed-off-by: Jeff Garzik <jgarzik@redhat.com>