From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1]
Date: Sat, 05 Apr 2008 10:17:34 +0200 [thread overview]
Message-ID: <47F7359E.1020105@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0804042331460.16995-100000@netrider.rowland.org>
On 04/05/2008 05:46 AM, Alan Stern wrote:
> Removing an interface's sysfs files before unregistering the interface
> doesn't work properly, because usb_unbind_interface() will reinstall
> altsetting 0 and thereby create new sysfs files. This patch (as1074)
> removes the files after the unregistration is finished. It's not
> quite as clean, but at least it works.
>
> Also, there's no need to check if an interface has been registered
> before removing its sysfs files. If it hasn't been registered then
> the files won't have been created, so usb_remove_sysfs_intf_files()
> will simply do nothing.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Jiri Slaby <jirislaby@gmail.com>
Works well, thanks.
next prev parent reply other threads:[~2008-04-05 8:17 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 4:32 2.6.25-rc8-mm1 Andrew Morton
2008-04-02 5:40 ` 2.6.25-rc8-mm1 Dmitri Vorobiev
2008-04-02 6:03 ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-02 17:33 ` 2.6.25-rc8-mm1 (mips build failure) Christoph Lameter
2008-04-02 18:29 ` Andrew Morton
2008-04-02 18:33 ` Christoph Lameter
2008-04-02 19:06 ` Sam Ravnborg
2008-04-03 16:02 ` Ralf Baechle
2008-04-03 22:17 ` Christoph Lameter
2008-04-03 23:26 ` Dmitri Vorobiev
2008-04-04 10:24 ` Ralf Baechle
2008-04-04 17:36 ` Christoph Lameter
2008-04-04 17:50 ` Christoph Lameter
2008-04-02 6:04 ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02 6:15 ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-02 6:25 ` [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc Kamalesh Babulal
2008-04-02 6:39 ` Andrew Morton
2008-04-02 7:08 ` Kamalesh Babulal
2008-04-02 7:17 ` Michael Ellerman
2008-04-02 17:09 ` Kamalesh Babulal
2008-04-02 18:15 ` Badari Pulavarty
2008-04-02 19:22 ` Badari Pulavarty
2008-04-02 21:57 ` Yinghai Lu
2008-04-02 22:24 ` Yinghai Lu
2008-04-04 9:24 ` Andy Whitcroft
2008-04-02 9:02 ` [BUILD_FAILURE] 2.6.25-rc8-mm1 build failure on x86_64 with randconfig Kamalesh Babulal
2008-04-02 10:49 ` 2.6.25-rc8-mm1 Miles Lane
2008-04-02 11:08 ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02 16:58 ` 2.6.25-rc8-mm1 Chatre, Reinette
2008-04-02 19:15 ` 2.6.25-rc8-mm1 Valdis.Kletnieks
2008-04-02 16:20 ` 2.6.25-rc8-mm1 sparc64 build problem: size of array 'type name' is negative Mariusz Kozlowski
2008-04-02 16:30 ` Andrew Morton
2008-04-02 19:12 ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c Valdis.Kletnieks
2008-04-02 19:27 ` Josef Bacik
2008-04-02 19:39 ` Andrew Morton
2008-04-02 19:41 ` Josef Bacik
2008-04-03 18:18 ` Stephen Smalley
2008-04-03 23:02 ` James Morris
2008-04-04 12:46 ` Stephen Smalley
2008-04-06 23:54 ` James Morris
2008-04-04 10:15 ` Jan Kara
2008-04-04 12:53 ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c' Josef Bacik
2008-04-03 18:25 ` 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c Stephen Smalley
2008-04-02 19:30 ` Andrew Morton
2008-04-03 8:57 ` Jan Kara
2008-04-03 12:11 ` 2.6.25-rc8-mm1 Dave Airlie
2008-04-03 16:59 ` 2.6.25-rc8-mm1 Andrew Morton
2008-04-03 23:08 ` 2.6.25-rc8-mm1: Intel SATA boot failure Tilman Schmidt
2008-04-03 23:17 ` Andrew Morton
2008-04-09 14:29 ` Tilman Schmidt
2008-04-14 0:28 ` Tilman Schmidt
2008-04-14 2:05 ` Andrew Morton
2008-04-15 23:33 ` Tilman Schmidt
2008-04-04 20:16 ` usb unbind/bind => WARNING at fs/sysfs/dir.c [Was: 2.6.25-rc8-mm1] Jiri Slaby
2008-04-04 20:51 ` Greg KH
2008-04-04 21:23 ` Alan Stern
2008-04-05 3:46 ` Alan Stern
2008-04-05 4:37 ` Greg KH
2008-04-05 14:16 ` Alan Stern
2008-04-05 8:17 ` Jiri Slaby [this message]
2008-04-07 6:21 ` 2.6.25-rc8-mm1 - BUG: scheduling while atomic: swapper/0/0xffffffff Valdis.Kletnieks
2008-04-07 6:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F7359E.1020105@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).