From: matthieu castet <castet.matthieu@free.fr>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Michael Trimarchi <trimarchimichael@yahoo.it>,
Andrew Morton <akpm@linux-foundation.org>,
Josh Boyer <jwboyer@gmail.com>
Subject: Re: [PATCH] jffs2 summary allocation
Date: Sat, 05 Apr 2008 16:05:43 +0200 [thread overview]
Message-ID: <47F78737.4050705@free.fr> (raw)
Hi,
I think the main problem is that mtd buffers are not dma compatible [1].
They can be allocated by vmalloc, don't be aligned on a page, ...
The problem was catch on jffs2 summary, but the same things could happen
in other places.
So for me the correct fix, is either to fix mtd to have all buffer dma
compatible or either fix mtd_dataflash to don't pass mtd buffer to spi
stack, but to allocate dma buffer and do some copy.
BTW aren't there sparse annotation to track dma buffer ?
Matthieu
[1] http://article.gmane.org/gmane.linux.drivers.mtd/20663
As for the original question... I'm not sure. At the moment I don't
believe it's true that all such buffers are suitable for DMA. Perhaps it
would be sensible for us to redefine the MTD API so that it is required
(and fix the users).
next reply other threads:[~2008-04-05 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 14:05 matthieu castet [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-04 10:23 [PATCH] jffs2 summary allocation Michael Trimarchi
2008-04-04 19:48 ` Andrew Morton
2008-04-04 20:09 ` Russell King - ARM Linux
2008-04-04 23:09 ` David Brownell
2008-04-04 23:21 ` Josh Boyer
2008-04-04 23:58 ` David Brownell
2008-04-05 1:11 ` Josh Boyer
2008-04-05 1:29 ` Kyungmin Park
2008-04-05 1:46 ` Andrew Morton
2008-04-05 2:41 ` David Brownell
2008-04-05 3:27 ` Andrew Morton
2008-04-05 2:17 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F78737.4050705@free.fr \
--to=castet.matthieu@free.fr \
--cc=akpm@linux-foundation.org \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trimarchimichael@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox