From: Jeff Garzik <jeff@garzik.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
magnus.damm@gmail.com, damm@igel.co.jp, lethal@linux-sh.org,
nico@cam.org, Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: Blackfin STAMP537 compiling error in 2.6.25-rc8
Date: Mon, 07 Apr 2008 04:13:46 -0400 [thread overview]
Message-ID: <47F9D7BA.6080708@garzik.org> (raw)
In-Reply-To: <386072610804070057w1eb65db5taeca77f8f3e36627@mail.gmail.com>
Bryan Wu wrote:
> We found the latest kernel compile failed with Blackfin STAMP537
> configuration on our daily build machine.
> ---
> CC drivers/net/smc91x.o
> drivers/net/smc91x.c: In function 'smc_rcv':
> drivers/net/smc91x.c:513: warning: passing argument 1 of 'insw' makes
> integer from pointer without a cast
> drivers/net/smc91x.c: In function 'smc_hardware_send_pkt':
> drivers/net/smc91x.c:620: warning: passing argument 1 of 'outsw' makes
> integer from pointer without a cast
> drivers/net/smc91x.c:1859:32: error: macro "SMC_GET_MAC_ADDR" requires
> 2 arguments, but only 1 given
> drivers/net/smc91x.c: In function 'smc_probe':
> drivers/net/smc91x.c:1859: error: 'SMC_GET_MAC_ADDR' undeclared (first
> use in this function)
> drivers/net/smc91x.c:1859: error: (Each undeclared identifier is
> reported only once
> drivers/net/smc91x.c:1859: error: for each function it appears in.)
> make[2]: *** [drivers/net/smc91x.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
> ---
>
> That is because my -mm tree fixing bug patch:
> (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9e6db60825ef7e7999abc610ce256ba768e58162)
> was merged into mainline before the smc91x API change patch in -mm:
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/smc91x-pass-along-private-data-v2.patch
>
> Did I miss something here? or this patch is on the way before 2.6.25
> final release?
It looks like I missed something... I thought akpm was going to send
the patch for -mm in?
If not, let's revert this one...
Jeff
next prev parent reply other threads:[~2008-04-07 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 7:57 Blackfin STAMP537 compiling error in 2.6.25-rc8 Bryan Wu
2008-04-07 8:13 ` Jeff Garzik [this message]
2008-04-07 8:15 ` Bryan Wu
2008-04-07 20:17 ` Jeff Garzik
2008-04-07 22:28 ` Andrew Morton
2008-04-08 2:08 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F9D7BA.6080708@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=damm@igel.co.jp \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=nico@cam.org \
--cc=torvalds@linux-foundation.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox