From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757489AbYDGKfA (ORCPT ); Mon, 7 Apr 2008 06:35:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754785AbYDGKev (ORCPT ); Mon, 7 Apr 2008 06:34:51 -0400 Received: from cantor.suse.de ([195.135.220.2]:49899 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbYDGKeu (ORCPT ); Mon, 7 Apr 2008 06:34:50 -0400 Message-ID: <47F9F8C9.2080807@suse.de> Date: Mon, 07 Apr 2008 12:34:49 +0200 From: Hannes Reinecke User-Agent: Thunderbird 1.5 (X11/20060317) MIME-Version: 1.0 To: Denys Vlasenko Cc: Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] debloat aic7xxx and aic79xx drivers References: <200803230440.40685.vda.linux@googlemail.com> <200803230441.22926.vda.linux@googlemail.com> <200803230442.02771.vda.linux@googlemail.com> In-Reply-To: <200803230442.02771.vda.linux@googlemail.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Denys, Denys Vlasenko wrote: > Adds statics, #ifdefs out huge amount of unused code, adds consts > > Signed-off-by: Denys Vlasenko > -- > vda > NACK. We need the #defines to print out the registers. And in either case the *_shipped files are in fact autogenerated by aic assembler, so we need to fix that one, too. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg)