From: Anthony Liguori <anthony@codemonkey.ws>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Balaji Rao <balajirrao@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio: remove overzealous BUG_ON.
Date: Mon, 07 Apr 2008 08:50:24 -0500 [thread overview]
Message-ID: <47FA26A0.3020701@codemonkey.ws> (raw)
In-Reply-To: <200804071430.28399.rusty__35361.6672721275$1207542780$gmane$org@rustcorp.com.au>
Rusty Russell wrote:
> The 'disable_cb' callback is designed as an optimization to tell the host
> we don't need callbacks now. As it is not reliable, the debug check is
> overzealous: it can happen on two CPUs at the same time. Document this.
>
> Even if it were reliable, the virtio_net driver doesn't disable
> callbacks on transmit so the START_USE/END_USE debugging reentrance
> protection can be easily tripped even on UP.
>
> Thanks to Balaji Rao for the bug report and testing.
I think the printk() in start_xmit should be removed too (or at least
rate limited).
Regards,
Anthony Liguori
next parent reply other threads:[~2008-04-07 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804071430.28399.rusty__35361.6672721275$1207542780$gmane$org@rustcorp.com.au>
2008-04-07 13:50 ` Anthony Liguori [this message]
2008-04-07 20:09 ` [PATCH] virtio: remove overzealous BUG_ON Rusty Russell
2008-04-07 4:30 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FA26A0.3020701@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=balajirrao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox