From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
Paul Hardwick <p.hardwick@option.com>
Subject: Re: [PATCH] tty/serial: Lay the foundations for the next set of reworks
Date: Tue, 08 Apr 2008 23:56:25 +0200 [thread overview]
Message-ID: <47FBEA09.6090507@gmail.com> (raw)
In-Reply-To: <20080408165839.47df4517@core>
On 04/08/2008 05:58 PM, Alan Cox wrote:
> - Remove private put_char method that does a write call for one char - we
> have that anyway
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc8-mm1/drivers/char/nozomi.c linux-2.6.25-rc8-mm1/drivers/char/nozomi.c
> --- linux.vanilla-2.6.25-rc8-mm1/drivers/char/nozomi.c 2008-04-08 11:34:51.000000000 +0100
> +++ linux-2.6.25-rc8-mm1/drivers/char/nozomi.c 2008-04-08 11:44:09.000000000 +0100
> @@ -1724,6 +1724,8 @@
> const struct ctrl_dl *ctrl_dl = &port->ctrl_dl;
> const struct ctrl_ul *ctrl_ul = &port->ctrl_ul;
>
> + /* Note: these could change under us but it is not clear this
> + matters if so */
> return (ctrl_ul->RTS ? TIOCM_RTS : 0) |
> (ctrl_ul->DTR ? TIOCM_DTR : 0) |
> (ctrl_dl->DCD ? TIOCM_CAR : 0) |
> @@ -1849,16 +1851,6 @@
> spin_unlock_irqrestore(&dc->spin_mutex, flags);
> }
>
> -/* just to discard single character writes */
> -static void ntty_put_char(struct tty_struct *tty, unsigned char c)
> -{
> - /*
> - * card does not react correct when we write single chars
> - * to the card, so we discard them
> - */
> - DBG2("PUT CHAR Function: %c", c);
> -}
> -
> /* Returns number of chars in buffer, called by tty layer */
> static s32 ntty_chars_in_buffer(struct tty_struct *tty)
> {
> @@ -1892,7 +1884,6 @@
> .unthrottle = ntty_unthrottle,
> .throttle = ntty_throttle,
> .chars_in_buffer = ntty_chars_in_buffer,
> - .put_char = ntty_put_char,
> .tiocmget = ntty_tiocmget,
> .tiocmset = ntty_tiocmset,
> };
Well, how exactly the card behaves on 1 byte write? And how did the .write
protect against it?
next prev parent reply other threads:[~2008-04-08 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 15:58 [PATCH] tty/serial: Lay the foundations for the next set of reworks Alan Cox
2008-04-08 21:56 ` Jiri Slaby [this message]
2008-04-08 22:13 ` Alan Cox
2008-04-09 6:57 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FBEA09.6090507@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox