From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757096AbYDJQL4 (ORCPT ); Thu, 10 Apr 2008 12:11:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755589AbYDJQLt (ORCPT ); Thu, 10 Apr 2008 12:11:49 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52985 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755567AbYDJQLs (ORCPT ); Thu, 10 Apr 2008 12:11:48 -0400 Message-ID: <47FE3B24.4020301@zytor.com> Date: Thu, 10 Apr 2008 09:07:00 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Linus Torvalds CC: Andi Kleen , Steven Rostedt , Andy Whitcroft , LKML , Ingo Molnar , Peter Zijlstra , akpm@linux-foundation.org, Rusty Russell , Glauber de Oliveira Costa , Jan Beulich , Thomas Gleixner , pinskia@gcc.gnu.org Subject: Re: [PATCH] pop previous section in alternative.c References: <47FD5D42.5000603@zytor.com> <87wsn6m6zt.fsf@basil.nowhere.org> <20080410094637.GW17915@shadowen.org> <20080410144114.GH10019@one.firstfloor.org> <20080410150544.GI10019@one.firstfloor.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > That would mark gcc itself as buggy, because gcc will move some things > into the #APP/#NO_APP thing, and sometimes doesn't end the #APP at all! > That is quite buggy indeed, since the whole #APP and #NO_APP string set are arbitrary strings that are part of the gcc configuration, marked as "what to insert before user assembly" and "what to insert after user assembly." They are not guaranteed to be simple comments, in fact. In fact, gas *is* sensitive to #APP ... #NO_APP, so they are not simple comments. -hpa