From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Theodore Ts'o" <tytso@mit.edu>, linux-mips@linux-mips.org
Cc: "Andrea Gelmini" <andrea.gelmini@gelma.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Leonid Yegoshin" <Leonid.Yegoshin@imgtec.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Matt Redfearn" <matt.redfearn@imgtec.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Ralf Bächle" <ralf@linux-mips.org>,
"Zubair Lutfullah Kakakhel" <Zubair.Kakakhel@imgtec.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: Further software improvements around Linux sequence API?
Date: Mon, 24 Oct 2016 20:10:27 +0200 [thread overview]
Message-ID: <47c7084e-21d8-4564-c237-84324dae17ab@users.sourceforge.net> (raw)
In-Reply-To: <20161024155112.ixdfi3ucs7sg2zgh@thunk.org>
> An experienced developer would be able to very easily spot that trying
> to optimize seq_printf() versus seq_puts() is barely going to be measurable.
Would you like to offer any incentives to use a more appropriate function
from this Linux programming interface for sequences?
> It's the sort of thing that a developer might fix while
> making other, more useful changes to a source file.
I get doubts when you expect that change possibilities with a higher
priority should and will almost always picked up before update candidates
with a lower impact.
> Well, please note that having a reputation of someone who insists on
> sending mostly junk patches (and like junk food, they may have some
> nutritive value; but that doesn't change the effect that the net
> benefit to person consuming them is marginal or negative), tends to
> give you a bad reputation, and may in fact be a hinderance towards
> your being able to attain "financial incentives".
I can not offer the “shiny gold nugget” or “pure diamond” so far directly
which is often preferred.
> If that is in fact your goal, I would gently suggest that you spend
> more time improving your skills, and learning more about higher-value
> ways you could contribute to the kernel, instead of spamming the
> kernel list with lots of low value patches.
* I could extend my source code search patterns in principle.
How many developers and software reviewers struggle with results
from existing code analysis tools?
* Will your interest occasionally grow for collateral software evolution?
> In the future if you are adding higher value improvements, and you want
> to do various cleanups, such as fixing up seq_printf -> seq_puts changes, sure.
Is this kind of feedback a contradiction at the moment when you seem to give
the impression that my software development reputation is so damaged in the
“junk food” sense that I could hardly achieve the software change mixture
which you would prefer?
Regards,
Markus
next prev parent reply other threads:[~2016-10-24 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 12:26 [PATCH 0/4] MIPS-kernel: Fine-tuning for two function implementations SF Markus Elfring
2016-10-24 12:27 ` [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() SF Markus Elfring
2016-10-24 13:13 ` Theodore Ts'o
2016-10-24 14:02 ` SF Markus Elfring
2016-10-24 14:20 ` Theodore Ts'o
2016-10-24 14:53 ` SF Markus Elfring
2016-10-24 15:51 ` Theodore Ts'o
2016-10-24 18:10 ` SF Markus Elfring [this message]
2016-10-24 12:28 ` [PATCH 2/4] MIPS/kernel/proc: Use seq_putc() in show_cpuinfo() SF Markus Elfring
2016-10-24 12:29 ` [PATCH 3/4] MIPS/kernel/proc: Replace 28 seq_printf() calls by seq_puts() " SF Markus Elfring
2016-10-24 12:30 ` [PATCH 4/4] MIPS/kernel/proc: Combine four seq_printf() calls into one call " SF Markus Elfring
2016-10-25 8:55 ` Geert Uytterhoeven
2016-10-25 9:08 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c7084e-21d8-4564-c237-84324dae17ab@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.gelmini@gelma.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=paul.gortmaker@windriver.com \
--cc=ralf@linux-mips.org \
--cc=tytso@mit.edu \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).