From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756169Ab0EBPHS (ORCPT ); Sun, 2 May 2010 11:07:18 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:20752 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755008Ab0EBPHP convert rfc822-to-8bit (ORCPT ); Sun, 2 May 2010 11:07:15 -0400 MIME-Version: 1.0 Message-ID: <47d6b5d9-beb5-4e49-9910-064d6f7b13e5@default> Date: Sun, 2 May 2010 08:05:29 -0700 (PDT) From: Dan Magenheimer To: Pavel Machek Cc: Avi Kivity , Jeremy Fitzhardinge , Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hugh.dickins@tiscali.co.uk, ngupta@vflare.org, JBeulich@novell.com, chris.mason@oracle.com, kurt.hackel@oracle.com, dave.mccracken@oracle.com, npiggin@suse.de, akpm@linux-foundation.org, riel@redhat.com Subject: RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview References: <4BD3377E.6010303@redhat.com> <1c02a94a-a6aa-4cbb-a2e6-9d4647760e91@default4BD43033.7090706@redhat.com> <20100428055538.GA1730@ucw.cz> <1272591924.23895.807.camel@nimitz> <4BDA8324.7090409@redhat.com> <084f72bf-21fd-4721-8844-9d10cccef316@default> <4BDB026E.1030605@redhat.com> <4BDB18CE.2090608@goop.org4BDB2069.4000507@redhat.com> <3a62a058-7976-48d7-acd2-8c6a8312f10f@default 20100502071059.GF1790@ucw.cz> In-Reply-To: <20100502071059.GF1790@ucw.cz> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 1.5.1.5.2 (401224) [OL 12.0.6514.5000] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090202.4BDD9503.00DC:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > So there are two users of frontswap for which the synchronous > > interface makes sense. I believe there may be more in the > > future and you disagree but, as Jeremy said, "a general Linux > > principle is not to overdesign interfaces for hypothetical users, > > only for real needs." We have demonstrated there is a need > > with at least two users so the debate is only whether the > > number of users is two or more than two. > > > > Frontswap is a very non-invasive patch and is very cleanly > > layered so that if it is not in the presence of either of > > the intended "users", it can be turned off in many different > > ways with zero overhead (CONFIG'ed off) or extremely small overhead > > (frontswap_ops is never set; or frontswap_ops is set but the > > underlying hypervisor doesn't support it so frontswap_poolid > > never gets set). > > Yet there are less invasive solutions available, like 'add trim > operation to swap_ops'. As Nitin pointed out much earlier in this thread: "No: trim or discard is not useful" I also think that trim does not do anything for the widely varying dynamically changing size that frontswap provides. > So what needs to be said here is 'frontswap is XX times faster than > swap_ops based solution on workload YY'. Are you asking me to demonstrate that swap-to-hypervisor-RAM is faster than swap-to-disk?