From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@altera.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Rao, Mahesh" <mahesh.rao@altera.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5
Date: Fri, 31 Oct 2025 09:00:40 +0100 [thread overview]
Message-ID: <47d6bf68-10a7-499c-8876-7e3f64e4b7bb@kernel.org> (raw)
In-Reply-To: <eef97a92-40ea-429d-8bc4-6fb22f05d2a7@altera.com>
On 31/10/2025 00:08, Romli, Khairul Anuar wrote:
> On 31/10/2025 12:33 am, Krzysztof Kozlowski wrote:
>>> I was excluding the iommu in the current patch series, not that I meant
>>> there is no iommu. It was meant for the future patches that will include
>>
>> Read your bindings again. They clearly do not list IOMMU, meaning there
>> is no IOMMU.
>>
>> Best regards,
>> Krzysztof
>
> I will add that in the next revision also after going through
> https://www.kernel.org/doc/Documentation/devicetree/bindings/writing-bindings.rst
>
> One question, if the property only meant for a specific compatible, do
> you accept the logical "if" statement to ensure that the property only
> for specific device but not others?
Yes, see example-schema how to do it (and property is always described
in top-level).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-31 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 3:30 [PATCH v2 0/3] Enable Service layer driver for Agilex5 Khairul Anuar Romli
2025-10-30 3:30 ` [PATCH v2 1/3] dt-bindings: firmware: Add Agilex5 SVC compatible string Khairul Anuar Romli
2025-10-30 7:56 ` Krzysztof Kozlowski
2025-10-30 3:30 ` [PATCH 2/3] arm64: dts: intel: Add Agilex5 SVC node with memory region Khairul Anuar Romli
2025-10-30 3:30 ` [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5 Khairul Anuar Romli
2025-10-30 7:57 ` Krzysztof Kozlowski
2025-10-30 7:58 ` Krzysztof Kozlowski
2025-10-30 11:35 ` Romli, Khairul Anuar
2025-10-30 16:33 ` Krzysztof Kozlowski
2025-10-30 23:08 ` Romli, Khairul Anuar
2025-10-31 8:00 ` Krzysztof Kozlowski [this message]
2025-10-31 8:12 ` Romli, Khairul Anuar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d6bf68-10a7-499c-8876-7e3f64e4b7bb@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=khairul.anuar.romli@altera.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh.rao@altera.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox