From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: [patch 4/9] x86: remove unnecessary tmp local variable
Date: Sat, 05 Apr 2008 22:39:07 +0900 [thread overview]
Message-ID: <47f7839e.1ebd7e0a.2fbf.00e4@mx.google.com> (raw)
In-Reply-To: 20080405133903.770639386@gmail.com
[-- Attachment #1: x86-io-apic-kill-tmp-var.patch --]
[-- Type: text/plain, Size: 1399 bytes --]
There is no reason to use obscurer name.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
arch/x86/kernel/io_apic_32.c | 3 +--
arch/x86/kernel/io_apic_64.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
Index: 2.6-git/arch/x86/kernel/io_apic_32.c
===================================================================
--- 2.6-git.orig/arch/x86/kernel/io_apic_32.c
+++ 2.6-git/arch/x86/kernel/io_apic_32.c
@@ -2028,8 +2028,7 @@ static inline void init_IO_APIC_traps(vo
* 0x80, because int 0x80 is hm, kind of importantish. ;)
*/
for (irq = 0; irq < NR_IRQS ; irq++) {
- int tmp = irq;
- if (IO_APIC_IRQ(tmp) && !irq_vector[tmp]) {
+ if (IO_APIC_IRQ(irq) && !irq_vector[irq]) {
/*
* Hmm.. We don't have an entry for this,
* so default to an old-fashioned 8259
Index: 2.6-git/arch/x86/kernel/io_apic_64.c
===================================================================
--- 2.6-git.orig/arch/x86/kernel/io_apic_64.c
+++ 2.6-git/arch/x86/kernel/io_apic_64.c
@@ -1516,8 +1516,7 @@ static inline void init_IO_APIC_traps(vo
* 0x80, because int 0x80 is hm, kind of importantish. ;)
*/
for (irq = 0; irq < NR_IRQS ; irq++) {
- int tmp = irq;
- if (IO_APIC_IRQ(tmp) && !irq_cfg[tmp].vector) {
+ if (IO_APIC_IRQ(irq) && !irq_cfg[irq].vector) {
/*
* Hmm.. We don't have an entry for this,
* so default to an old-fashioned 8259
--
next prev parent reply other threads:[~2008-04-05 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080405133903.770639386@gmail.com>
2008-04-05 13:39 ` [patch 1/9] x86: avoid redundant loop in io_apic_level_ack_pending() Akinobu Mita
2008-04-05 13:39 ` [patch 2/9] x86: use ioapic_read_entry() and ioapic_write_entry() Akinobu Mita
2008-04-05 13:39 ` [patch 3/9] x86: remove unnecessary memset() Akinobu Mita
2008-04-05 13:39 ` Akinobu Mita [this message]
2008-04-05 13:39 ` [patch 5/9] x86: use cpumask_of_cpu() Akinobu Mita
2008-04-05 13:39 ` [patch 6/9] x86: use cpu_online() Akinobu Mita
2008-04-05 13:39 ` [patch 7/9] use BUILD_BUG_ON() for the size of struct intel_mp_floating Akinobu Mita
2008-04-05 13:39 ` [patch 8/9] x86_64: use MP_intsrc_info() Akinobu Mita
2008-04-05 13:39 ` [patch 9/9] x86: use bitmap library for pin_programmed Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f7839e.1ebd7e0a.2fbf.00e4@mx.google.com \
--to=akinobu.mita@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox