* [PATCH v3 0/1]extcon: ptn5150: Add usb-typec support for Intel LGM SoC
@ 2020-08-27 6:51 Ramuthevar,Vadivel MuruganX
2020-08-27 6:51 ` [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability Ramuthevar,Vadivel MuruganX
0 siblings, 1 reply; 6+ messages in thread
From: Ramuthevar,Vadivel MuruganX @ 2020-08-27 6:51 UTC (permalink / raw)
To: cw00.choi, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li, Ramuthevar,Vadivel MuruganX
Add usb-typec detection support for the Intel LGM SoC based boards.
Original driver is not supporting usb detection on Intel LGM SoC based boards
then we debugged and fixed the issue, but before sending our patches Mr.Krzyszto
has sent the same kind of patches, so I have rebased over his latest patches
which is present in maintainer tree.
Built and tested it's working fine, overthat created the new patch.
Thanks to Chanwoo Choi for the review comments and suggestions
---
v3:
- Chanwoo Choi review comments update
- replace 'capabiliy' to 'state' in commit message
- add blank line
v2:
- Krzyszto review comments update
- squash my previous patches 1 to 5 as single patch
- add extcon_set_property_capability for EXTCON_USB and EXTCON_PROP_USB_TYPEC_POLARITY
Ramuthevar Vadivel Murugan (1):
extcon: ptn5150: Set the VBUS and POLARITY property capability
drivers/extcon/extcon-ptn5150.c | 7 +++++++
1 file changed, 7 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
2020-08-27 6:51 [PATCH v3 0/1]extcon: ptn5150: Add usb-typec support for Intel LGM SoC Ramuthevar,Vadivel MuruganX
@ 2020-08-27 6:51 ` Ramuthevar,Vadivel MuruganX
2020-08-27 7:56 ` Chanwoo Choi
0 siblings, 1 reply; 6+ messages in thread
From: Ramuthevar,Vadivel MuruganX @ 2020-08-27 6:51 UTC (permalink / raw)
To: cw00.choi, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li, Ramuthevar Vadivel Murugan
From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
Set the capability value of property for VBUS and POLARITY.
Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
---
drivers/extcon/extcon-ptn5150.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 841c9fe211f1..20d49a54c36e 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
return ret;
}
+ extcon_set_property_capability(info->edev, EXTCON_USB,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_TYPEC_POLARITY);
+
/* Initialize PTN5150 device and print vendor id and version id */
ret = ptn5150_init_dev_type(info);
if (ret)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
2020-08-27 7:56 ` Chanwoo Choi
@ 2020-08-27 7:53 ` Ramuthevar, Vadivel MuruganX
2020-08-27 8:11 ` Chanwoo Choi
0 siblings, 1 reply; 6+ messages in thread
From: Ramuthevar, Vadivel MuruganX @ 2020-08-27 7:53 UTC (permalink / raw)
To: Chanwoo Choi, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li
Hi,
On 27/8/2020 3:56 pm, Chanwoo Choi wrote:
> On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Set the capability value of property for VBUS and POLARITY.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>> drivers/extcon/extcon-ptn5150.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>> index 841c9fe211f1..20d49a54c36e 100644
>> --- a/drivers/extcon/extcon-ptn5150.c
>> +++ b/drivers/extcon/extcon-ptn5150.c
>> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>> return ret;
>> }
>>
>> + extcon_set_property_capability(info->edev, EXTCON_USB,
>> + EXTCON_PROP_USB_VBUS);
>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>> + EXTCON_PROP_USB_VBUS);
>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>
> Above codes used the space for the indentation to keep the vertical line.
> I think that we better to use tab for the indentation.
>
> If there are no objection, I'll fix and then apply it.
Thank you!, no objection , please fix it.
Regards
Vadivel
>
>> +
>> /* Initialize PTN5150 device and print vendor id and version id */
>> ret = ptn5150_init_dev_type(info);
>> if (ret)
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
2020-08-27 6:51 ` [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability Ramuthevar,Vadivel MuruganX
@ 2020-08-27 7:56 ` Chanwoo Choi
2020-08-27 7:53 ` Ramuthevar, Vadivel MuruganX
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2020-08-27 7:56 UTC (permalink / raw)
To: Ramuthevar,Vadivel MuruganX, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li
On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> Set the capability value of property for VBUS and POLARITY.
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> ---
> drivers/extcon/extcon-ptn5150.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
> index 841c9fe211f1..20d49a54c36e 100644
> --- a/drivers/extcon/extcon-ptn5150.c
> +++ b/drivers/extcon/extcon-ptn5150.c
> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
> return ret;
> }
>
> + extcon_set_property_capability(info->edev, EXTCON_USB,
> + EXTCON_PROP_USB_VBUS);
> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
> + EXTCON_PROP_USB_VBUS);
> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
> + EXTCON_PROP_USB_TYPEC_POLARITY);
Above codes used the space for the indentation to keep the vertical line.
I think that we better to use tab for the indentation.
If there are no objection, I'll fix and then apply it.
> +
> /* Initialize PTN5150 device and print vendor id and version id */
> ret = ptn5150_init_dev_type(info);
> if (ret)
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
2020-08-27 8:11 ` Chanwoo Choi
@ 2020-08-27 8:00 ` Ramuthevar, Vadivel MuruganX
0 siblings, 0 replies; 6+ messages in thread
From: Ramuthevar, Vadivel MuruganX @ 2020-08-27 8:00 UTC (permalink / raw)
To: Chanwoo Choi, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li
Hi,
On 27/8/2020 4:11 pm, Chanwoo Choi wrote:
> On 8/27/20 4:53 PM, Ramuthevar, Vadivel MuruganX wrote:
>> Hi,
>>
>> On 27/8/2020 3:56 pm, Chanwoo Choi wrote:
>>> On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
>>>> From: Ramuthevar Vadivel Murugan<vadivel.muruganx.ramuthevar@linux.intel.com>
>>>>
>>>> Set the capability value of property for VBUS and POLARITY.
>>>>
>>>> Signed-off-by: Ramuthevar Vadivel Murugan<vadivel.muruganx.ramuthevar@linux.intel.com>
>>>> ---
>>>> drivers/extcon/extcon-ptn5150.c | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>>>> index 841c9fe211f1..20d49a54c36e 100644
>>>> --- a/drivers/extcon/extcon-ptn5150.c
>>>> +++ b/drivers/extcon/extcon-ptn5150.c
>>>> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>>>> return ret;
>>>> }
>>>> + extcon_set_property_capability(info->edev, EXTCON_USB,
>>>> + EXTCON_PROP_USB_VBUS);
>>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>>> + EXTCON_PROP_USB_VBUS);
>>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>>> Above codes used the space for the indentation to keep the vertical line.
>>> I think that we better to use tab for the indentation.
>>>
>>> If there are no objection, I'll fix and then apply it.
>> Thank you!, no objection , please fix it.
> Applied it. Thanks.
Thank you so much for applying.
Regards
Vadivel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
2020-08-27 7:53 ` Ramuthevar, Vadivel MuruganX
@ 2020-08-27 8:11 ` Chanwoo Choi
2020-08-27 8:00 ` Ramuthevar, Vadivel MuruganX
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2020-08-27 8:11 UTC (permalink / raw)
To: vadivel.muruganx.ramuthevar, linux-kernel
Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, heikki.krogerus,
cheol.yong.kim, qi-ming.wu, yin1.li
Hi,
On 8/27/20 4:53 PM, Ramuthevar, Vadivel MuruganX wrote:
> Hi,
>
> On 27/8/2020 3:56 pm, Chanwoo Choi wrote:
>> On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
>>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>>
>>> Set the capability value of property for VBUS and POLARITY.
>>>
>>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>> ---
>>> drivers/extcon/extcon-ptn5150.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>>> index 841c9fe211f1..20d49a54c36e 100644
>>> --- a/drivers/extcon/extcon-ptn5150.c
>>> +++ b/drivers/extcon/extcon-ptn5150.c
>>> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>>> return ret;
>>> }
>>> + extcon_set_property_capability(info->edev, EXTCON_USB,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>>
>> Above codes used the space for the indentation to keep the vertical line.
>> I think that we better to use tab for the indentation.
>>
>> If there are no objection, I'll fix and then apply it.
> Thank you!, no objection , please fix it.
Applied it. Thanks.
>
> Regards
> Vadivel
>>
>>> +
>>> /* Initialize PTN5150 device and print vendor id and version id */
>>> ret = ptn5150_init_dev_type(info);
>>> if (ret)
>>>
>>
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-27 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-27 6:51 [PATCH v3 0/1]extcon: ptn5150: Add usb-typec support for Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-08-27 6:51 ` [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability Ramuthevar,Vadivel MuruganX
2020-08-27 7:56 ` Chanwoo Choi
2020-08-27 7:53 ` Ramuthevar, Vadivel MuruganX
2020-08-27 8:11 ` Chanwoo Choi
2020-08-27 8:00 ` Ramuthevar, Vadivel MuruganX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox