From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761216AbYDLIuh (ORCPT ); Sat, 12 Apr 2008 04:50:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760863AbYDLIuL (ORCPT ); Sat, 12 Apr 2008 04:50:11 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:41456 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760494AbYDLIuI (ORCPT ); Sat, 12 Apr 2008 04:50:08 -0400 Message-ID: <480077BB.4000109@garzik.org> Date: Sat, 12 Apr 2008 04:50:03 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Krzysztof Halasa CC: Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC References: <20080411221448.22b69ff5.akpm@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Halasa wrote: > --- a/drivers/net/wan/Kconfig > +++ b/drivers/net/wan/Kconfig > @@ -150,9 +150,13 @@ config HDLC_FR > > config HDLC_PPP > tristate "Synchronous Point-to-Point Protocol (PPP) support" > - depends on HDLC > + depends on HDLC && BROKEN > help > Generic HDLC driver supporting PPP over WAN connections. > + This module is currently broken and will cause a kernel panic > + when a device configured in PPP mode is activated. > + > + It will be replaced by new PPP implementation in Linux 2.6.26. > > If unsure, say N. applied