From: Jacek Luczak <difrost.kernel@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
tglx@linutronix.de
Subject: Re: [PATCH] x86: setup_trampoline() - fix section mismatch warning
Date: Sat, 12 Apr 2008 13:00:32 +0200 [thread overview]
Message-ID: <48009650.5090306@gmail.com> (raw)
In-Reply-To: <20080411175006.GA31716@uranus.ravnborg.org>
Hi Sam,
Sam Ravnborg pisze:
[!snip]
>> diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
>> index 4aedd0b..2a07e67 100644
>> --- a/arch/x86/kernel/trampoline_64.S
>> +++ b/arch/x86/kernel/trampoline_64.S
>> @@ -32,7 +32,7 @@
>>
>> /* We can free up trampoline after bootup if cpu hotplug is not supported. */
>> #ifndef CONFIG_HOTPLUG_CPU
>> -.section .init.data, "aw", @progbits
>> +.section .cpuinit.data, "aw", @progbits
>> #else
>> .section .rodata, "a", @progbits
>> #endif
>
> The correct fix would be to drop the
> preprocessor directves and use __CPUINITDATA
Hmm...IMO this should stay in that form at least now.
I will make some tests with __CPUINITDATA (look into objects, etc.) and later on we can
switch. Is it OK for you?
>
> Like this: (hand edited):
>
>> diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
>> index 4aedd0b..2a07e67 100644
>> --- a/arch/x86/kernel/trampoline_64.S
>> +++ b/arch/x86/kernel/trampoline_64.S
>> @@ -32,7 +32,7 @@
>>
>> /* We can free up trampoline after bootup if cpu hotplug is not supported. */
>> #ifndef CONFIG_HOTPLUG_CPU
>> -.section .init.data, "aw", @progbits
>> -#else
>> -.section .rodata, "a", @progbits
>> -#endif
>> +__CPUINITDATA
>
> If your testing confirms this then please apply similar fix to the _32.S
> version of the file too.
Yep, I'm now working on 32bit stuff.
-Jacek
next prev parent reply other threads:[~2008-04-12 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 19:16 [PATCH] x86: setup_trampoline() - fix section mismatch warning Jacek Luczak
2008-04-11 9:03 ` Ingo Molnar
2008-04-11 17:50 ` Sam Ravnborg
2008-04-12 11:00 ` Jacek Luczak [this message]
2008-04-12 16:56 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48009650.5090306@gmail.com \
--to=difrost.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox