From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756427AbYDLRzA (ORCPT ); Sat, 12 Apr 2008 13:55:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755111AbYDLRyu (ORCPT ); Sat, 12 Apr 2008 13:54:50 -0400 Received: from h155.mvista.com ([63.81.120.155]:44892 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755032AbYDLRyt (ORCPT ); Sat, 12 Apr 2008 13:54:49 -0400 Message-ID: <4800F73E.3000802@ru.mvista.com> Date: Sat, 12 Apr 2008 21:54:06 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ide: add struct ide_dma_ops References: <200803091700.46136.bzolnier@gmail.com> <200803181512.50134.bzolnier@gmail.com> <47FF636E.4070903@ru.mvista.com> <200804121432.03366.bzolnier@gmail.com> In-Reply-To: <200804121432.03366.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: >>>> Now where is the code which selects the correct dma_ops for the >>>>>HPT36x/370/372/372N chip with device ID 4 I'm asking you? :-) >>>fixed >> Not actually... :-/ > Arghhh. I see now that the HPT370/370A needs a special handling... Yes, and a lot of. :-) > (HPT372/372N has already been handled by 'idx++') Didn't grasp this at first - the init. code grew somewhat convoluted... > [...] >>>@@ -1483,6 +1489,7 @@ static const struct ide_port_info hpt366 >>> .enablebits = {{0x50,0x04,0x04}, {0x54,0x04,0x04}}, >>> .udma_mask = ATA_UDMA5, >>> .port_ops = &hpt3xx_port_ops, >>>+ .dma_ops = &hpt370_dma_ops, >> Wrong -- HPT374 should have hpt37x_dma_ops... > Yep, thanks for catching it. > interdiff between v2->v3: > [...] > v3: > * Two bugs slipped in v2 (noticed by Sergei): > - use correct DMA ops for HPT374 (for real this time) > - handle HPT370/HPT370A properly Acked-by: Sergei Shtylyov MBR, Sergei