From: Jacek Luczak <difrost.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: ijc@hellion.org.uk, tglx@linutronix.de,
LKML <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: *_pagetable_setup_[start,done] crap ?
Date: Sun, 13 Apr 2008 11:31:46 +0200 [thread overview]
Message-ID: <4801D302.8070005@gmail.com> (raw)
In-Reply-To: <20080413074225.GF20332@elte.hu>
Ingo Molnar pisze:
> * Jacek Luczak <difrost.kernel@gmail.com> wrote:
>
>> Ohh... and prototypes are wrong:
>> diff --git a/include/asm-x86/pgtable_32.h b/include/asm-x86/pgtable_32.h
>> index 6cbc520..2167879 100644
>> --- a/include/asm-x86/pgtable_32.h
>> +++ b/include/asm-x86/pgtable_32.h
>> @@ -204,8 +204,8 @@ do { \
>> */
>> #define update_mmu_cache(vma, address, pte) do { } while (0)
>>
>> -void native_pagetable_setup_start(pgd_t *base);
>> -void native_pagetable_setup_done(pgd_t *base);
>> +extern void native_pagetable_setup_start(pgd_t *base) __init;
>> +extern void native_pagetable_setup_done(pgd_t *base) __init;
>
> while generally it's nice to add 'extern' to prototypes, it's not an
> outright bug to not have it. Also, __init is a must-have in the
> definition only - it should not be added to the prototype.
>
Sounds reasonably. Sorry for calling something crap. When I slept well it looks fine and clear for me.
-Jacek
prev parent reply other threads:[~2008-04-13 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 16:20 *_pagetable_setup_[start,done] crap ? Jacek Luczak
2008-04-13 7:42 ` Ingo Molnar
2008-04-13 9:31 ` Jacek Luczak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4801D302.8070005@gmail.com \
--to=difrost.kernel@gmail.com \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox