public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* microblaze: Merge window + git
@ 2008-04-11  7:50 Michal Simek
  2008-04-11 10:51 ` Stefan Richter
  0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2008-04-11  7:50 UTC (permalink / raw)
  To: linux-kernel

Hi everybody,

Can you tell me when is open next merge window?

and my next question is about GIT.

I have second release at my git server and I have some changes which you
reported. I would like to collect all changes in the same set of patches.

I mean I have patch with 4 files and I did next changes. I would like to
integrate these changes to the same patches. Is it possible to do it?
It is easier to review all changes together.

I think it is no good way to send first release with reported bugs and new diffs.

Thanks,
Michal Simek
www.monstr.eu



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: microblaze: Merge window + git
  2008-04-11  7:50 microblaze: Merge window + git Michal Simek
@ 2008-04-11 10:51 ` Stefan Richter
  2008-04-11 12:45   ` Ilpo Järvinen
  2008-04-12 21:21   ` H. Peter Anvin
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Richter @ 2008-04-11 10:51 UTC (permalink / raw)
  To: monstr; +Cc: linux-kernel

Michal Simek wrote:
> Can you tell me when is open next merge window?

When 2.6.25 is being released.

> and my next question is about GIT.
> 
> I have second release at my git server and I have some changes which you
> reported. I would like to collect all changes in the same set of patches.
> 
> I mean I have patch with 4 files and I did next changes. I would like to
> integrate these changes to the same patches. Is it possible to do it?
> It is easier to review all changes together.
> 
> I think it is no good way to send first release with reported bugs and new diffs.

You can combine several commits into one in a few ways.  Of course the
combined commit is an entirely new one (with its own SHA1 etc.).  One
possible way:

# you are at <commit0>
$ git cherry-pick --no-commit <commit1>   # apply but don't commit yet
$ git cherry-pick --edit <commit2>   # apply, edit the changelog, commit

There will now be a <commit3> whose parent is <commit0>.  <commit3>
incorporates changes of <commit1> and <commit2>.

Another way:

# you are at <commit0>
$ patch < ~/diff-from-somewhere
$ git commit --amend   # replace <commit0> by new amended commit

There will now be a <commit4> instead of <commit0>, with the same
parent(s) which <commit0> had.  <commit4> incorporates changes of
<commit0> and the diff.

However, I am no expert on doing these things in git since I only
develop with quilt.  I use git only to publish the state of development
and the state for upstream merge.
-- 
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: microblaze: Merge window + git
  2008-04-11 10:51 ` Stefan Richter
@ 2008-04-11 12:45   ` Ilpo Järvinen
  2008-04-12 21:21   ` H. Peter Anvin
  1 sibling, 0 replies; 5+ messages in thread
From: Ilpo Järvinen @ 2008-04-11 12:45 UTC (permalink / raw)
  To: monstr; +Cc: LKML, Stefan Richter

On Fri, 11 Apr 2008, Stefan Richter wrote:

> Michal Simek wrote:
> > Can you tell me when is open next merge window?
> 
> When 2.6.25 is being released.
> 
> > and my next question is about GIT.
> > 
> > I have second release at my git server and I have some changes which you
> > reported. I would like to collect all changes in the same set of patches.
> > 
> > I mean I have patch with 4 files and I did next changes. I would like to
> > integrate these changes to the same patches. Is it possible to do it?
> > It is easier to review all changes together.
> > 
> > I think it is no good way to send first release with reported bugs and new diffs.
> 
> You can combine several commits into one in a few ways.  Of course the
> combined commit is an entirely new one (with its own SHA1 etc.).  One
> possible way:
> 
> # you are at <commit0>
> $ git cherry-pick --no-commit <commit1>   # apply but don't commit yet
> $ git cherry-pick --edit <commit2>   # apply, edit the changelog, commit
> 
> There will now be a <commit3> whose parent is <commit0>.  <commit3>
> incorporates changes of <commit1> and <commit2>.
> 
> Another way:
> 
> # you are at <commit0>
> $ patch < ~/diff-from-somewhere
> $ git commit --amend   # replace <commit0> by new amended commit
> 
> There will now be a <commit4> instead of <commit0>, with the same
> parent(s) which <commit0> had.  <commit4> incorporates changes of
> <commit0> and the diff.

If you have a tree which has those four commits on top, it's rather easy 
with git:

$ git-reset --soft HEAD^^^
$ git-commit --amend

...In order the git-reset --soft to leave the index into the desired 
state, no pending stuff should be in index before beginning (index
is the thing controlled with cmds like git-add/git-update-index/etc.).

...The commit's message is taken from the bottommost of those four 
original commits.

-- 
 i.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: microblaze: Merge window + git
  2008-04-11 10:51 ` Stefan Richter
  2008-04-11 12:45   ` Ilpo Järvinen
@ 2008-04-12 21:21   ` H. Peter Anvin
  2008-04-13 11:32     ` Michal Simek
  1 sibling, 1 reply; 5+ messages in thread
From: H. Peter Anvin @ 2008-04-12 21:21 UTC (permalink / raw)
  To: Stefan Richter; +Cc: monstr, linux-kernel

Stefan Richter wrote:
> Michal Simek wrote:
>> Can you tell me when is open next merge window?
> 
> When 2.6.25 is being released.
> 

... which is expected to be within the week, so you're quite in luck.

	-hpa

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: microblaze: Merge window + git
  2008-04-12 21:21   ` H. Peter Anvin
@ 2008-04-13 11:32     ` Michal Simek
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2008-04-13 11:32 UTC (permalink / raw)
  To: H. Peter Anvin; +Cc: Stefan Richter, linux-kernel

Thanks for your answers,

I integrate all reported bugs and I sent request to Microblaze community
to review. I will clean patches to compact pack for your review.

Regards,
Michal Simek
www.monstr.eu

> Stefan Richter wrote:
>> Michal Simek wrote:
>>> Can you tell me when is open next merge window?
>>
>> When 2.6.25 is being released.
>>
> 
> ... which is expected to be within the week, so you're quite in luck.
> 
>     -hpa
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-04-13 11:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11  7:50 microblaze: Merge window + git Michal Simek
2008-04-11 10:51 ` Stefan Richter
2008-04-11 12:45   ` Ilpo Järvinen
2008-04-12 21:21   ` H. Peter Anvin
2008-04-13 11:32     ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox