From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbYDNJWx (ORCPT ); Mon, 14 Apr 2008 05:22:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750886AbYDNJWp (ORCPT ); Mon, 14 Apr 2008 05:22:45 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:63394 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751146AbYDNJWo (ORCPT ); Mon, 14 Apr 2008 05:22:44 -0400 Message-ID: <480321D9.7020507@cn.fujitsu.com> Date: Mon, 14 Apr 2008 17:20:25 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Paul Menage CC: KAMEZAWA Hiroyuki , Andrew Morton , Balbir Singh , Pavel Emelianov , LKML , "linux-mm@kvack.org" Subject: Re: [PATCH] memcg: fix oops in oom handling References: <4802FF10.6030905@cn.fujitsu.com> <20080414161428.27f3ee59.kamezawa.hiroyu@jp.fujitsu.com> <6599ad830804140053y4bcdceeatc9763c1e8c1aaf44@mail.gmail.com> <480310C5.1070102@cn.fujitsu.com> In-Reply-To: <480310C5.1070102@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Li Zefan wrote: > Paul Menage wrote: >> On Mon, Apr 14, 2008 at 12:14 AM, KAMEZAWA Hiroyuki >> wrote: >>> Paul, I have one confirmation. Lock hierarchy of >>> cgroup_lock() >>> -> read_lock(&tasklist_lock) >>> >>> is ok ? (I think this is ok.) >> Should be fine, I think. >> >> Have you built/booted with lockdep? >> > > I should have done this. :( > > I'll check it. > I've done the test, and nothing is broken ;)