[2.6 patch] xtensa: don't offer PARPORT_PC

[2.6 patch] xtensa: don't offer PARPORT_PC

[Adrian Bunk]

This patch fixes the following compile error:

<--  snip  -->

...
  CC [M]  drivers/parport/parport_pc.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:67:25: error: asm/parport.h: No such file or directory
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c: In function 'parport_pc_find_ports':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:3215: error: implicit declaration of function 'parport_pc_find_nonpci_ports'
make[3]: *** [drivers/parport/parport_pc.o] Error 1

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
2a5e7c5402f0f38ab160eca47b905b23d1e71a3d diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
index 209b4a4..0670918 100644
--- a/drivers/parport/Kconfig
+++ b/drivers/parport/Kconfig
@@ -36,7 +36,7 @@ if PARPORT
 config PARPORT_PC
 	tristate "PC-style hardware"
 	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
-		(!M68K || ISA) && !MN10300
+		(!M68K || ISA) && !MN10300 && !XTENSA
 	---help---
 	  You should say Y here if you have a PC-style parallel port. All
 	  IBM PC compatible computers and some Alphas have PC-style

Re: [2.6 patch] xtensa: don't offer PARPORT_PC

[Rogan Dawes]

Adrian Bunk wrote:

>  config PARPORT_PC
>  	tristate "PC-style hardware"
>  	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
> -		(!M68K || ISA) && !MN10300
> +		(!M68K || ISA) && !MN10300 && !XTENSA

Pardon a possibly stupid question here, but would it not make more sense 
to code the architectures for which these various devices *are* 
possible, rather than requiring each architecture to go through the 
entire config file and add their own "we don't do this" for many entries?

As seen, it is easy for them to be missed, hence all these recent patches.

The way I look at it, it is a lot easier to require that the arch 
maintainer adds specific entries to get their particular hardware 
working, rather than go through a working setup and figure out how much 
they can take away before it breaks.

Rogan

Re: [2.6 patch] xtensa: don't offer PARPORT_PC

[Alan Cox]

On Mon, 14 Apr 2008 22:55:51 +0300
Adrian Bunk <bunk@kernel.org> wrote:

> This patch fixes the following compile error:
> 
> <--  snip  -->
> 
> ...
>   CC [M]  drivers/parport/parport_pc.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:67:25: error: asm/parport.h: No such file or directory
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c: In function 'parport_pc_find_ports':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:3215: error: implicit declaration of function 'parport_pc_find_nonpci_ports'
> make[3]: *** [drivers/parport/parport_pc.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

If xtensa has PCI then if you fix up the headers so the PCI stuff works
we'll be in a better shape.

Re: [2.6 patch] xtensa: don't offer PARPORT_PC

[Alan Cox]

> Pardon a possibly stupid question here, but would it not make more sense 
> to code the architectures for which these various devices *are* 
> possible, rather than requiring each architecture to go through the 
> entire config file and add their own "we don't do this" for many entries?

For any with PCI bus the right fix is to add the header files.
-- 
--
	"Alan, I'm getting a bit worried about you."
				-- Linus Torvalds

Re: [2.6 patch] xtensa: don't offer PARPORT_PC

[Adrian Bunk]

On Mon, Apr 14, 2008 at 10:31:24PM +0100, Alan Cox wrote:
> On Mon, 14 Apr 2008 22:55:51 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
> 
> > This patch fixes the following compile error:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC [M]  drivers/parport/parport_pc.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:67:25: error: asm/parport.h: No such file or directory
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c: In function 'parport_pc_find_ports':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:3215: error: implicit declaration of function 'parport_pc_find_nonpci_ports'
> > make[3]: *** [drivers/parport/parport_pc.o] Error 1
> > 
> > <--  snip  -->
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> If xtensa has PCI then if you fix up the headers so the PCI stuff works
> we'll be in a better shape.

The only merged platform does not support PCI, and I don't have any 
xtensa hardware for knowing what to put there.

Chris?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] xtensa: don't offer PARPORT_PC

[Chris Zankel]

Hi Adrian,

Most of the boards with Xtensa don't have PCI, and the PCI bridge on the
two boards I know have PCI are more or less broken. One (with a V3)
doesn't support byte/word accesses and the other one has broken
PCI-Master to main memory connection. I'll work on the one that has
only 32-bit access and will try to fix it.


Thanks,
-Chris

Adrian Bunk wrote:
> On Mon, Apr 14, 2008 at 10:31:24PM +0100, Alan Cox wrote:
>> On Mon, 14 Apr 2008 22:55:51 +0300
>> Adrian Bunk <bunk@kernel.org> wrote:
>>
>>> This patch fixes the following compile error:
>>>
>>> <--  snip  -->
>>>
>>> ...
>>>   CC [M]  drivers/parport/parport_pc.o
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:67:25: error: asm/parport.h: No such file or directory
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c: In function 'parport_pc_find_ports':
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/parport/parport_pc.c:3215: error: implicit declaration of function 'parport_pc_find_nonpci_ports'
>>> make[3]: *** [drivers/parport/parport_pc.o] Error 1
>>>
>>> <--  snip  -->
>>>
>>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>> If xtensa has PCI then if you fix up the headers so the PCI stuff works
>> we'll be in a better shape.
> 
> The only merged platform does not support PCI, and I don't have any 
> xtensa hardware for knowing what to put there.
> 
> Chris?
> 
> cu
> Adrian
>