From: Tony Battersby <tonyb@cybernetics.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Michael Chan <mchan@broadcom.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: TG3 network data corruption regression 2.6.24/2.6.23.4
Date: Tue, 15 Apr 2008 11:39:27 -0400 [thread overview]
Message-ID: <4804CC2F.6030403@cybernetics.com> (raw)
In-Reply-To: <20080415001207.GA11852@localdomain>
Matt Carlson wrote:
> Hi Tony. Sorry for the radio silence.
>
> Michael and I have discussed this problem a bit. Another possibility is
> that the chip may be having difficulty with non-dword aligned TX buffers.
> Since we already know the RX side has the same problem, it isn't so
> far-fetched to think that perhaps it can affect the TX side too. Can
> you give the following patch a try and see if the corruption still
> happens?
>
>
Thanks, your patch fixes the problem (tested on 2.6.24.4). However, I
had to change "(skb->mac_header & 3)" in your patch to "((long)
skb->mac_header & 3)" since mac_header is a pointer rather than an int
on 32-bit systems.
Tested-by: Tony Battersby <tonyb@cybernetics.com>
next prev parent reply other threads:[~2008-04-15 16:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 22:41 TG3 network data corruption regression 2.6.24/2.6.23.4 Tony Battersby
2008-02-19 0:32 ` Michael Chan
2008-02-19 0:35 ` David Miller
2008-02-19 1:04 ` Michael Chan
2008-02-19 16:16 ` Tony Battersby
2008-02-19 19:11 ` Michael Chan
2008-02-19 19:26 ` Tony Battersby
2008-02-19 22:14 ` Tony Battersby
2008-02-19 23:52 ` Michael Chan
2008-02-20 15:01 ` Tony Battersby
2008-02-20 1:38 ` Matt Carlson
2008-02-20 16:13 ` Tony Battersby
2008-02-20 21:29 ` Tony Battersby
2008-02-20 23:04 ` Tony Battersby
2008-02-20 23:08 ` David Miller
2008-02-20 23:17 ` Michael Chan
2008-02-20 3:45 ` Herbert Xu
2008-02-20 15:18 ` Tony Battersby
2008-04-15 0:12 ` Matt Carlson
2008-04-15 15:39 ` Tony Battersby [this message]
2008-04-16 3:31 ` David Miller
2008-04-16 15:40 ` Michael Chan
2008-04-16 20:17 ` Matt Carlson
2008-04-16 21:00 ` Tony Battersby
2008-04-18 6:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4804CC2F.6030403@cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox