public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Paul Collins <paul@burly.ondioline.org>
Cc: Jeff Garzik <jeff@garzik.org>, linux-kernel@vger.kernel.org
Subject: Re: ata2: SATA link down (SStatus 611 SControl 300)
Date: Wed, 16 Apr 2008 07:26:59 +0900	[thread overview]
Message-ID: <48052BB3.2090509@gmail.com> (raw)
In-Reply-To: <87y77ex1oh.fsf@burly.wgtn.ondioline.org>

Hello, Paul.

Paul Collins wrote:
> Tejun Heo <htejun@gmail.com> writes:
> 
>>> ata2: XXX about to resume
>>> ata2: SATA link down (SStatus 611 SControl 0)
>> The link is already in slumber mode before the driver doing anything
>> to it.  Is there any related setting in BIOS?
> 
> I found a setting labelled "SATA Power Management".  It was set to
> "Enable".  When I set it to "Disable", 2.6.25-rc9 detected the optical
> drive.

This can't be something changed between 2.6.24 and 2.6.25-rc9.  Can you 
please double check that?

>> Also, can you please give a shot at the attached patch?
> 
> I tried this patch with "SATA Power Management" on both settings.  In
> each case it detected the optical drive.

Good, so it seems later ich's need its SPM fields written or link reset 
to get out of powersave mode.  Inhibiting PM modes via IPM isn't enough, 
which BTW is sane.

Jeff, this one looks like another rationale for favoring hardreset over 
softreset && I don't see how we can fix this for 2.6.25.  We can try to 
write to SPM from link_resume() but the field being newly added in SATA 
2.5, I don't feel comfortable about it.

Thanks.

-- 
tejun

  reply	other threads:[~2008-04-15 22:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 21:48 ata2: SATA link down (SStatus 611 SControl 300) Paul Collins
2008-04-15  1:53 ` Tejun Heo
2008-04-15  2:30   ` Paul Collins
2008-04-15  2:57     ` Tejun Heo
2008-04-15  3:24       ` Paul Collins
2008-04-15  4:01         ` Tejun Heo
2008-04-15 21:12           ` Paul Collins
2008-04-15 22:26             ` Tejun Heo [this message]
2008-04-15 22:43               ` Paul Collins
2008-04-16  0:15                 ` Tejun Heo
2008-04-16  0:33                   ` Tejun Heo
2008-04-16  1:06                     ` Paul Collins
2008-04-16  1:27                       ` [PATCH #upstream-fixes] libata: force hardreset if the link is in powersave mode Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48052BB3.2090509@gmail.com \
    --to=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@burly.ondioline.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox