From: Max Krasnyanskiy <maxk@qualcomm.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Vitaliy Ivanov <vitalivanov@gmail.com>,
Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>,
marcel@holtmann.org, linux-bluetooth@vger.kernel.org
Subject: Re: hci_usb: remove macro code obfuscation
Date: Wed, 16 Apr 2008 10:19:15 -0700 [thread overview]
Message-ID: <48063513.7050505@qualcomm.com> (raw)
In-Reply-To: <20080416105851.GB1621@elf.ucw.cz>
Pavel Machek wrote:
> On Wed 2008-04-16 13:51:37, Vitaliy Ivanov wrote:
>> On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>>> I had trouble figuring out what the code does. atomic_inc/dec
>>> management is actually pretty simple, but it is needlessly obfuscated
>>> with macros. Fix that.
>>>
>>> Signed-off-by: Pavel Machek <pavel@suse.cz>
>>>
>>> I had trouble figuring out what the code does. atomic_inc/dec
>>> management is actually pretty simple, but it is needlessly obfuscated
>>> with macros. Fix that.
>>>
>>> Signed-off-by: Pavel Machek <pavel@suse.cz>
>>
>> Got it from the first time;)
>>
>> Do you think that now code looks better? As for me it's not...
>
> Yes. Hiding & operator deep inside macro is evil for one thing. Plus
> it is no longer clear what the code does with the macros in there.
In general I would agree in this case it seems to actually make code clearer
(I prefer original macros that is).
Anyway, I do not mind the change.
btw Marcel told me that all this queuing stuff does not actually make sense
anymore. USB core did not support this before and HCI driver performance
sucked without it. Marcel is telling me that things have changed.
So. Pavel, while you're at it can you maybe whack that stuff out completely ?
I mean all this custom _urb stuff that I did was eventually supposed to move
into usb core. Then I stopped working on Bluetooth and it never happened. It'd
be nice to clean that up since it seems that most of the latest bug reports
are related to this urb business.
Thanx
Max
next prev parent reply other threads:[~2008-04-16 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 10:42 hci_usb: remove macro code obfuscation Pavel Machek
2008-04-16 10:51 ` Vitaliy Ivanov
2008-04-16 10:58 ` Pavel Machek
2008-04-16 17:19 ` Max Krasnyanskiy [this message]
2008-04-19 16:18 ` Pavel Machek
2008-04-16 18:29 ` Andrew Morton
2008-04-16 18:37 ` Max Krasnyanskiy
2008-04-16 20:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48063513.7050505@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=akpm@osdl.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavel@ucw.cz \
--cc=vitalivanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox