From: David Wilder <dwilder@us.ibm.com>
To: prasad@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, mathieu.desnoyers@polymtl.ca,
hunt@redhat.com
Subject: Re: [RFC Patch 1/1] debugfs_printk and debugfs_dump interface
Date: Wed, 16 Apr 2008 14:25:18 -0700 [thread overview]
Message-ID: <48066EBE.3040608@us.ibm.com> (raw)
In-Reply-To: <20080415112603.GA5770@in.ibm.com>
K. Prasad wrote:
>
> +
> +struct debugfs_printk_data {
> + char *parent_dir;
> + char *dir;
> + int exists;
> + int buf_size;
> + int sub_buf_size;
> +};
How about adding a "flags" field here to hold the trace channel flags.
Pass the flags through to trace_setup(). This way the caller can
control the trace options.
Add a description of debugfs_printk() and debugfs_dump() to
Documentation/trace.txt.
next prev parent reply other threads:[~2008-04-16 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 11:14 [RFC Patch 0/1] Enhancements to 'trace' infrastructure K. Prasad
2008-04-15 11:26 ` [RFC Patch 1/1] debugfs_printk and debugfs_dump interface K. Prasad
2008-04-16 21:25 ` David Wilder [this message]
2008-04-21 12:43 ` K. Prasad
2008-04-21 17:14 ` Randy Dunlap
2008-04-22 5:22 ` K. Prasad
2008-04-22 14:53 ` Randy Dunlap
2008-04-23 7:59 ` K. Prasad
2008-04-24 21:23 ` David Wilder
2008-04-25 7:42 ` K. Prasad
2008-04-25 8:19 ` K. Prasad
2008-04-28 0:50 ` Michael Ellerman
2008-04-28 4:48 ` K. Prasad
2008-04-28 4:54 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48066EBE.3040608@us.ibm.com \
--to=dwilder@us.ibm.com \
--cc=hunt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=prasad@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox