* [PATCH 0/4] selftests: Fix trivial nitpicks
@ 2017-04-13 16:56 SeongJae Park
2017-04-13 16:56 ` [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park
2017-04-13 16:56 ` [PATCH 2/4] " SeongJae Park
0 siblings, 2 replies; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 16:56 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
This patchset fixes trivial nitpicks under selftests.
SeongJae Park (4):
selftests/Makefile: Add missed closing `"` in comment
selftests/Makefile: Add missed PHONY targets
selftests/vm/run_vmtests: Polish output text
selftests/vm/run_vmtests: Fix wrong comment
tools/testing/selftests/Makefile | 4 ++--
tools/testing/selftests/vm/run_vmtests | 26 +++++++++++++-------------
2 files changed, 15 insertions(+), 15 deletions(-)
--
2.12.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
2017-04-13 16:56 [PATCH 0/4] selftests: Fix trivial nitpicks SeongJae Park
@ 2017-04-13 16:56 ` SeongJae Park
2017-04-13 22:02 ` Shuah Khan
2017-04-13 16:56 ` [PATCH 2/4] " SeongJae Park
1 sibling, 1 reply; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 16:56 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index d8593f1251ec..395ab296c084 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -39,7 +39,7 @@ TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
# Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
TARGETS_HOTPLUG = cpu-hotplug
TARGETS_HOTPLUG += memory-hotplug
--
2.12.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
2017-04-13 16:56 ` [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park
@ 2017-04-13 22:02 ` Shuah Khan
2017-04-13 23:38 ` SeongJae Park
0 siblings, 1 reply; 12+ messages in thread
From: Shuah Khan @ 2017-04-13 22:02 UTC (permalink / raw)
To: SeongJae Park; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 04/13/2017 10:56 AM, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d8593f1251ec..395ab296c084 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -39,7 +39,7 @@ TARGETS += x86
> TARGETS += zram
> #Please keep the TARGETS list alphabetically sorted
> # Run "make quicktest=1 run_tests" or
> -# "make quicktest=1 kselftest from top level Makefile
> +# "make quicktest=1 kselftest" from top level Makefile
>
> TARGETS_HOTPLUG = cpu-hotplug
> TARGETS_HOTPLUG += memory-hotplug
>
This patch is missing changelog - please add and resend.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
2017-04-13 22:02 ` Shuah Khan
@ 2017-04-13 23:38 ` SeongJae Park
2017-04-13 23:43 ` [PATCH v2] " SeongJae Park
2017-04-13 23:44 ` [PATCH v2] selftests/Makefile: Add missed PHONY targets SeongJae Park
0 siblings, 2 replies; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 23:38 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel@vger.kernel.org
On Fri, Apr 14, 2017 at 7:02 AM, Shuah Khan <shuah@kernel.org> wrote:
> On 04/13/2017 10:56 AM, SeongJae Park wrote:
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>> tools/testing/selftests/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index d8593f1251ec..395ab296c084 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -39,7 +39,7 @@ TARGETS += x86
>> TARGETS += zram
>> #Please keep the TARGETS list alphabetically sorted
>> # Run "make quicktest=1 run_tests" or
>> -# "make quicktest=1 kselftest from top level Makefile
>> +# "make quicktest=1 kselftest" from top level Makefile
>>
>> TARGETS_HOTPLUG = cpu-hotplug
>> TARGETS_HOTPLUG += memory-hotplug
>>
>
> This patch is missing changelog - please add and resend.
OK, I will resend it as a reply to this.
Thanks,
SeongJae Park
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] selftests/Makefile: Add missed closing `"` in comment
2017-04-13 23:38 ` SeongJae Park
@ 2017-04-13 23:43 ` SeongJae Park
2017-04-27 13:50 ` Shuah Khan
2017-04-13 23:44 ` [PATCH v2] selftests/Makefile: Add missed PHONY targets SeongJae Park
1 sibling, 1 reply; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 23:43 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
A comment for make command usage in `selftets/Makefile` has opening `"`
but no closing `"`. This commit adds the missed `"` in the comment.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index d8593f1251ec..395ab296c084 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -39,7 +39,7 @@ TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
# Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
TARGETS_HOTPLUG = cpu-hotplug
TARGETS_HOTPLUG += memory-hotplug
--
2.12.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] selftests/Makefile: Add missed closing `"` in comment
2017-04-13 23:43 ` [PATCH v2] " SeongJae Park
@ 2017-04-27 13:50 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2017-04-27 13:50 UTC (permalink / raw)
To: SeongJae Park; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 04/13/2017 05:43 PM, SeongJae Park wrote:
> A comment for make command usage in `selftets/Makefile` has opening `"`
> but no closing `"`. This commit adds the missed `"` in the comment.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d8593f1251ec..395ab296c084 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -39,7 +39,7 @@ TARGETS += x86
> TARGETS += zram
> #Please keep the TARGETS list alphabetically sorted
> # Run "make quicktest=1 run_tests" or
> -# "make quicktest=1 kselftest from top level Makefile
> +# "make quicktest=1 kselftest" from top level Makefile
>
> TARGETS_HOTPLUG = cpu-hotplug
> TARGETS_HOTPLUG += memory-hotplug
>
Applied to linux-kselftest next for 4.12-rc1
thanks for the patch.
-- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] selftests/Makefile: Add missed PHONY targets
2017-04-13 23:38 ` SeongJae Park
2017-04-13 23:43 ` [PATCH v2] " SeongJae Park
@ 2017-04-13 23:44 ` SeongJae Park
1 sibling, 0 replies; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 23:44 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
`selftests/Makefile` is defining only `install` as entire PHONY target
though there are few more PHONY targets including `run_tests`. This
commit defines them as the PHONY targets.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 395ab296c084..26ce4f7168be 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -133,4 +133,4 @@ clean:
make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
done;
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
--
2.12.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
2017-04-13 16:56 [PATCH 0/4] selftests: Fix trivial nitpicks SeongJae Park
2017-04-13 16:56 ` [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park
@ 2017-04-13 16:56 ` SeongJae Park
2017-04-13 22:03 ` Shuah Khan
1 sibling, 1 reply; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 16:56 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 395ab296c084..26ce4f7168be 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -133,4 +133,4 @@ clean:
make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
done;
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
--
2.12.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
2017-04-13 16:56 ` [PATCH 2/4] " SeongJae Park
@ 2017-04-13 22:03 ` Shuah Khan
2017-04-13 23:45 ` SeongJae Park
0 siblings, 1 reply; 12+ messages in thread
From: Shuah Khan @ 2017-04-13 22:03 UTC (permalink / raw)
To: SeongJae Park; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 04/13/2017 10:56 AM, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 395ab296c084..26ce4f7168be 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -133,4 +133,4 @@ clean:
> make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
> done;
>
> -.PHONY: install
> +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
>
Missing changelog - please add and resend.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
2017-04-13 22:03 ` Shuah Khan
@ 2017-04-13 23:45 ` SeongJae Park
2017-04-13 23:47 ` [PATCH v2] " SeongJae Park
0 siblings, 1 reply; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 23:45 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel@vger.kernel.org
On Fri, Apr 14, 2017 at 7:03 AM, Shuah Khan <shuah@kernel.org> wrote:
> On 04/13/2017 10:56 AM, SeongJae Park wrote:
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>> tools/testing/selftests/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index 395ab296c084..26ce4f7168be 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -133,4 +133,4 @@ clean:
>> make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
>> done;
>>
>> -.PHONY: install
>> +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
>>
>
> Missing changelog - please add and resend.
Ok, I will send it as a reply to this.
Thanks,
SeongJae Park
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] selftests/Makefile: Add missed PHONY targets
2017-04-13 23:45 ` SeongJae Park
@ 2017-04-13 23:47 ` SeongJae Park
2017-04-27 13:52 ` Shuah Khan
0 siblings, 1 reply; 12+ messages in thread
From: SeongJae Park @ 2017-04-13 23:47 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, SeongJae Park
`selftests/Makefile` is defining only `install` as entire PHONY target
though there are few more PHONY targets including `run_tests`. This
commit defines them as the PHONY targets.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 395ab296c084..26ce4f7168be 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -133,4 +133,4 @@ clean:
make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
done;
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
--
2.12.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] selftests/Makefile: Add missed PHONY targets
2017-04-13 23:47 ` [PATCH v2] " SeongJae Park
@ 2017-04-27 13:52 ` Shuah Khan
0 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2017-04-27 13:52 UTC (permalink / raw)
To: SeongJae Park; +Cc: linux-kselftest, linux-kernel, shuah Khan
On 04/13/2017 05:47 PM, SeongJae Park wrote:
> `selftests/Makefile` is defining only `install` as entire PHONY target
> though there are few more PHONY targets including `run_tests`. This
> commit defines them as the PHONY targets.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> tools/testing/selftests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 395ab296c084..26ce4f7168be 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -133,4 +133,4 @@ clean:
> make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
> done;
>
> -.PHONY: install
> +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
>
Applied to linux-kselftest next for 4.12-rc1
thanks for the patch.
-- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-04-27 13:52 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-13 16:56 [PATCH 0/4] selftests: Fix trivial nitpicks SeongJae Park
2017-04-13 16:56 ` [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park
2017-04-13 22:02 ` Shuah Khan
2017-04-13 23:38 ` SeongJae Park
2017-04-13 23:43 ` [PATCH v2] " SeongJae Park
2017-04-27 13:50 ` Shuah Khan
2017-04-13 23:44 ` [PATCH v2] selftests/Makefile: Add missed PHONY targets SeongJae Park
2017-04-13 16:56 ` [PATCH 2/4] " SeongJae Park
2017-04-13 22:03 ` Shuah Khan
2017-04-13 23:45 ` SeongJae Park
2017-04-13 23:47 ` [PATCH v2] " SeongJae Park
2017-04-27 13:52 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox