Re: [PATCH 3/3] slub: add hooks for kmemcheck

[Pekka Enberg <penberg@cs.helsinki.fi>]

Hi,

Christoph Lameter wrote:
>>>  Should this not go into some kmemcheck.h file?
>> The implementations of these prototypes are in mm/slub_kmemcheck.c.
>> They are only ever called from slub.c since they represent the
>> interface between SLUB and kmemcheck.
>>
>> Would you rather have it in include/linux/slub_kmemcheck.h?
> 
> Well lets see what Pekka says.

Well, I've tried to push for "generic" kmemcheck hooks so that they can 
be used by SLAB/SLOB too but Vegard has always talked me out of it. Of 
course, I have long forgotten the rationale.

But anyway, slub_kmemcheck.h sounds okay and I wonder if we should put 
it in mm/ instead of include/linux/ as it's not supposed to be included 
by anyone except SLUB?

Christoph Lameter wrote:
>> Currently, with SLAB/SLUB debugging enabled, the page flag will be
>> cleared, then accessed in check_object(), thus generating a few
>> accesses to the page. It is safer to delay the clearing of the page
>> flag until no more accesses can be generated for the page.
> 
> Hmmmm.. Okay that is already dealt with by a patch in Pekka's tree.

And merged by Linus now.

			Pekka