From: "H. Peter Anvin" <hpa@zytor.com>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] x86: remove unused code and data in nexgen.c
Date: Sun, 20 Apr 2008 00:22:29 -0400 [thread overview]
Message-ID: <480AC505.1030301@zytor.com> (raw)
In-Reply-To: <1208660074-7324-3-git-send-email-dmitri.vorobiev@gmail.com>
Dmitri Vorobiev wrote:
> Nobody calls the function nexgen_init_cpu(), therefore it
> can be removed. The variable nexgen_cpu_dev is used only by
> this function, so this patch removes useless data as well.
>
> This patch was build-tested using defconfigs for i386 and x86_64.
> It also survived a few randconfig instances for i386. Runtime
> tests were performed by booting 32-bit and 64-bit x86 boxen up to
> the shell prompt.
NAK. This is broken.
The reason nexgen_cpu_dev is unreferenced is because the file is missing
a cpu_vendor_dev_register(), which should be added.
-hpa
next prev parent reply other threads:[~2008-04-20 4:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 2:54 [PATCH 0/4] x86: random clean-ups Dmitri Vorobiev
2008-04-20 2:54 ` [PATCH 1/4] x86: remove unused function amd_init_cpu() Dmitri Vorobiev
2008-04-20 2:54 ` [PATCH 2/4] x86: remove unused code and data in nexgen.c Dmitri Vorobiev
2008-04-20 4:22 ` H. Peter Anvin [this message]
2008-04-20 10:33 ` [PATCH 2/2 v2] x86: remove unused function, register the cpu vendor " Dmitri Vorobiev
2008-04-20 18:51 ` [PATCH 2/4] x86: remove unused code and data " Andi Kleen
2008-04-20 19:24 ` Dmitri Vorobiev
2008-04-20 19:34 ` H. Peter Anvin
2008-04-20 19:45 ` Dmitri Vorobiev
2008-04-20 19:47 ` H. Peter Anvin
2008-04-20 20:03 ` Andi Kleen
2008-04-20 20:26 ` H. Peter Anvin
2008-04-23 18:19 ` Alan Cox
2008-04-23 19:02 ` Dmitri Vorobiev
2008-04-20 2:54 ` [PATCH 3/4] x86_64: the standard_io_resources[] array can become static Dmitri Vorobiev
2008-04-20 2:54 ` [PATCH 4/4] x86: conditionally compile sysfs stuff in intel_cacheinfo.c Dmitri Vorobiev
2008-04-21 12:25 ` [PATCH 0/4] x86: random clean-ups Ingo Molnar
[not found] ` <90edad820804210541h26c8e66dh70895f32e4b4038d@mail.gmail.com>
2008-04-22 14:02 ` Ingo Molnar
2008-04-22 19:18 ` Dmitri Vorobiev
2008-04-22 19:22 ` Ingo Molnar
2008-04-22 19:37 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480AC505.1030301@zytor.com \
--to=hpa@zytor.com \
--cc=dmitri.vorobiev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox