From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760189AbYDURR5 (ORCPT ); Mon, 21 Apr 2008 13:17:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754856AbYDURRr (ORCPT ); Mon, 21 Apr 2008 13:17:47 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:34689 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754610AbYDURRr (ORCPT ); Mon, 21 Apr 2008 13:17:47 -0400 Message-ID: <480CCBEC.3080905@oracle.com> Date: Mon, 21 Apr 2008 10:16:28 -0700 From: Sunil Mushran User-Agent: Thunderbird 1.5.0.14ubu (X11/20080306) MIME-Version: 1.0 To: Adrian Bunk CC: Joel Becker , Mark Fasheh , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static References: <20080421084937.GU26897@cs181133002.pp.htv.fi> In-Reply-To: <20080421084937.GU26897@cs181133002.pp.htv.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adrian Bunk wrote: > This patch makes the following needlessly global functions static: > - stringify_lockname() > - dlm_debug_put() > > Signed-off-by: Adrian Bunk > Acked-by: Sunil Mushran > --- > > fs/ocfs2/dlm/dlmdebug.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > fec83555cf8467e5c932fa52177b8f567eb84d94 diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c > index 5f6d858..1b81dcb 100644 > --- a/fs/ocfs2/dlm/dlmdebug.c > +++ b/fs/ocfs2/dlm/dlmdebug.c > @@ -44,7 +44,8 @@ > #define MLOG_MASK_PREFIX ML_DLM > #include "cluster/masklog.h" > > -int stringify_lockname(const char *lockname, int locklen, char *buf, int len); > +static int stringify_lockname(const char *lockname, int locklen, char *buf, > + int len); > > void dlm_print_one_lock_resource(struct dlm_lock_resource *res) > { > @@ -251,7 +252,8 @@ EXPORT_SYMBOL_GPL(dlm_errname); > * > * For more on lockname formats, please refer to dlmglue.c and ocfs2_lockid.h. > */ > -int stringify_lockname(const char *lockname, int locklen, char *buf, int len) > +static int stringify_lockname(const char *lockname, int locklen, char *buf, > + int len) > { > int out = 0; > __be64 inode_blkno_be; > @@ -368,7 +370,7 @@ static void dlm_debug_free(struct kref *kref) > kfree(dc); > } > > -void dlm_debug_put(struct dlm_debug_ctxt *dc) > +static void dlm_debug_put(struct dlm_debug_ctxt *dc) > { > if (dc) > kref_put(&dc->debug_refcnt, dlm_debug_free); > > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel@oss.oracle.com > http://oss.oracle.com/mailman/listinfo/ocfs2-devel >