From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757033AbYDUUdc (ORCPT ); Mon, 21 Apr 2008 16:33:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752044AbYDUUdZ (ORCPT ); Mon, 21 Apr 2008 16:33:25 -0400 Received: from s36.avahost.net ([74.53.95.194]:57699 "EHLO s36.avahost.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbYDUUdY (ORCPT ); Mon, 21 Apr 2008 16:33:24 -0400 X-Greylist: delayed 3720 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Apr 2008 16:33:24 EDT Message-ID: <480CEB7D.8070702@katalix.com> Date: Mon, 21 Apr 2008 20:31:09 +0100 From: James Chapman Organization: Katalix Systems Ltd User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Krzysztof Halasa CC: David Miller , alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org, jeff@garzik.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC References: <20080412115950.1cbb9cfa@core> <20080418.153256.253949503.davem@davemloft.net> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - s36.avahost.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - katalix.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Halasa wrote: > David Miller writes: > >> I'll fix it properly because I know you won't do the work. > > Great to read that. > > Just few friendly after all notes so that you don't waste your time > learning that yourself: > - my patch didn't give us a third PPP implementation, we already have > three: generic PPP, syncppp and PPP for ISDN :-) > - of those, both generic PPP and (I think) ISDN PPP are in a good > shape > - generic PPP is specialized for dial-up async devices and has the > required features (in kernel and in userspace pppd) - auth, > multi-line, compression etc. It's a "lets give /dev/ttyS* a network > device" implementation. Generic ppp isn't specialized at all, and it isn't limited to async serial devices. PPPoE, PPPoATM and L2TP use it. > - ISDN PPP does for ISDN cards basically the same as generic PPP does > for terminals. They are completely different from syncppp as the > needs are completely different. Fixed-line PPP must be small and > fast, and self-contained. > That's why I came to an idea that leaving syncppp and the old drivers > in their current bit-rotting state which nobody can really fix, and > using another (fourth, and third when syncppp eventually dies) PPP > implementation is the only way out of this situation. Can you elaborate on why the code that uses syncppp can't use the generic ppp code together with a userspace ppp control protocol implementation like pppd? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development