Re: [PATCH] kgdb: trivial sparse fixes in kgdb test-suite

Jason Wessel
2008-04-21T19:50:21Z

Harvey Harrison wrote:
> Shadowed variable and integer as NULL pointer fixes:
> drivers/misc/kgdbts.c:877:6: warning: symbol 'sys_open_test' shadows
an earlier one
> drivers/misc/kgdbts.c:537:27: originally declared here
> drivers/misc/kgdbts.c:378:22: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:386:22: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:468:30: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:472:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:502:30: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:506:30: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:509:30: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:523:20: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:527:20: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:530:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:541:21: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:545:21: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:548:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:559:30: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:563:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:573:16: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:574:19: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:578:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:588:16: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:589:19: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:593:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:602:16: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:604:15: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:925:3: warning: Using plain integer as NULL pointer
> drivers/misc/kgdbts.c:938:3: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

This patch looked fine Harvey, I queued it for the next pull request at:

http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=shortlog;h=for_linus

I made one minor change to 5 different code comments so as to make the
checkpatch.pl's 80 character check happy.

Thanks,
Jason.