From: Tejun Heo <htejun@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <greg@kroah.com>,
oliver@neukum.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
zaitcev@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] klist: implement KLIST_INIT() and DEFINE_KLIST()
Date: Tue, 22 Apr 2008 22:10:11 +0900 [thread overview]
Message-ID: <480DE3B3.6050702@gmail.com> (raw)
In-Reply-To: <1208869591.7115.263.camel@twins>
Peter Zijlstra wrote:
>> These locks don't nest so being in the same class should be okay and I
>> was following what (at least some of) other __SPIN_LOCK_UNLOCKED users
>> are doing. If putting these locks into separate classes is the RTTD, sure.
>
> Ah, they'll actually be in seprate classes all of the same name. So I
> think it is cleaner to cause them to have separate names too.
>
> see look_up_lock_class() in kernel/lockdep.c:
>
> /*
> * Static locks do not have their class-keys yet - for them the key
> * is the lock object itself:
> */
> if (unlikely(!lock->key))
> lock->key = (void *)lock;
Ah.. I'll put change it to name. Thanks.
--
tejun
next prev parent reply other threads:[~2008-04-22 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 9:57 [PATCH 1/2] klist: implement KLIST_INIT() and DEFINE_KLIST() Tejun Heo
2008-04-22 9:58 ` [PATCH] klist: implement klist_add_{after|before}() Tejun Heo
2008-04-28 23:51 ` patch klist-implement-klist_add_-after-before.patch added to gregkh-2.6 tree gregkh
2008-04-22 12:57 ` [PATCH 1/2] klist: implement KLIST_INIT() and DEFINE_KLIST() Peter Zijlstra
2008-04-22 13:03 ` Tejun Heo
2008-04-22 13:06 ` Peter Zijlstra
2008-04-22 13:10 ` Tejun Heo [this message]
2008-04-25 16:37 ` Greg KH
2008-04-25 18:16 ` [PATCH 1/2 UPDATED] " Tejun Heo
2008-04-25 22:30 ` Greg KH
2008-04-25 22:40 ` Tejun Heo
2008-04-28 23:51 ` patch klist-implement-klist_init-and-define_klist.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480DE3B3.6050702@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox