From: Eric Sandeen <sandeen@redhat.com>
To: linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 2/4] mark lockdep functions as noinline_for_stack
Date: Tue, 22 Apr 2008 10:54:04 -0500 [thread overview]
Message-ID: <480E0A1C.8080408@redhat.com> (raw)
In-Reply-To: <480E06A6.1080803@redhat.com>
Use the self-documenting noinline_for_stack attribute
in lockdep functions.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: linux-2.6.25/kernel/lockdep.c
===================================================================
--- linux-2.6.25.orig/kernel/lockdep.c 2008-04-22 10:31:08.158469196 -0500
+++ linux-2.6.25/kernel/lockdep.c 2008-04-22 10:51:17.107410380 -0500
@@ -878,7 +878,7 @@ static struct held_lock *check_source, *
* Print a dependency chain entry (this is only done when a deadlock
* has been detected):
*/
-static noinline int
+static noinline_for_stack int
print_circular_bug_entry(struct lock_list *target, unsigned int depth)
{
if (debug_locks_silent)
@@ -895,7 +895,7 @@ print_circular_bug_entry(struct lock_lis
* When a circular dependency is detected, print the
* header first:
*/
-static noinline int
+static noinline_for_stack int
print_circular_bug_header(struct lock_list *entry, unsigned int depth)
{
struct task_struct *curr = current;
@@ -920,7 +920,7 @@ print_circular_bug_header(struct lock_li
return 0;
}
-static noinline int print_circular_bug_tail(void)
+static noinline_for_stack int print_circular_bug_tail(void)
{
struct task_struct *curr = current;
struct lock_list this;
@@ -945,7 +945,7 @@ static noinline int print_circular_bug_t
#define RECURSION_LIMIT 40
-static int noinline print_infinite_recursion_bug(void)
+static int noinline_for_stack print_infinite_recursion_bug(void)
{
if (!debug_locks_off_graph_unlock())
return 0;
@@ -959,7 +959,7 @@ static int noinline print_infinite_recur
* Prove that the dependency graph starting at <entry> can not
* lead to <target>. Print an error and return 0 if it does.
*/
-static noinline int
+static noinline_for_stack int
check_noncircular(struct lock_class *source, unsigned int depth)
{
struct lock_list *entry;
@@ -1001,7 +1001,7 @@ static struct lock_class *forwards_match
* Return 1 otherwise and keep <forwards_match> unchanged.
* Return 0 on error.
*/
-static noinline int
+static noinline_for_stack int
find_usage_forwards(struct lock_class *source, unsigned int depth)
{
struct lock_list *entry;
@@ -1040,7 +1040,7 @@ find_usage_forwards(struct lock_class *s
* Return 1 otherwise and keep <backwards_match> unchanged.
* Return 0 on error.
*/
-static noinline int
+static noinline_for_stack int
find_usage_backwards(struct lock_class *source, unsigned int depth)
{
struct lock_list *entry;
next prev parent reply other threads:[~2008-04-22 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 15:39 [PATCH 0/4] mark various functions as noinline_for_stack Eric Sandeen
2008-04-22 15:51 ` [PATCH 1/4] mark sys_mount helper " Eric Sandeen
2008-04-22 15:54 ` Eric Sandeen [this message]
2008-04-22 15:55 ` [PATCH 3/4] mark loop " Eric Sandeen
2008-04-22 15:57 ` [PATCH 4/4] mark inflate " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E0A1C.8080408@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox