From: Eric Sandeen <sandeen@sandeen.net>
To: Joe Perches <joe@perches.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix max-stack calculators to skip canary
Date: Tue, 22 Apr 2008 13:09:17 -0500 [thread overview]
Message-ID: <480E29CD.1010203@sandeen.net> (raw)
In-Reply-To: <1208885594.8636.23.camel@localhost>
Joe Perches wrote:
> Wouldn't it be better to have exactly the same code?
> How about using a statement expression macro?
>
> #define DEBUG_STACK_FREE(process) \
> ({ \
> unsigned long *n = end_of_stack(process); \
> do { /* Skip over canary */\
> n++; \
> } while (!*n); \
> (unsigned long)n - (unsigned long)end_of_stack(process); \
> })
>
That'd probably be good although I don't think we like macros anymore :)
-Eric
next prev parent reply other threads:[~2008-04-22 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 3:44 [PATCH] use canary at end of stack to indicate overruns at oops time Eric Sandeen
2008-04-22 4:20 ` Arjan van de Ven
2008-04-22 8:44 ` Ingo Molnar
2008-04-22 16:44 ` Eric Sandeen
2008-04-22 17:18 ` [PATCH] Fix max-stack calculators to skip canary Eric Sandeen
2008-04-22 17:33 ` Joe Perches
2008-04-22 18:09 ` Eric Sandeen [this message]
2008-04-28 17:28 ` Ingo Molnar
2008-04-22 21:38 ` [PATCH V2] use canary at end of stack to indicate overruns at oops time Eric Sandeen
2008-04-22 22:14 ` Harvey Harrison
2008-04-22 22:28 ` Eric Sandeen
2008-04-28 17:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E29CD.1010203@sandeen.net \
--to=sandeen@sandeen.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox