From: Marcel Selhorst <tpm@selhorst.net>
To: Adrian Bunk <bunk@kernel.org>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [2.6 patch] tpm_bios.c: make 2 structs static
Date: Wed, 23 Apr 2008 12:12:35 +0200 [thread overview]
Message-ID: <480F0B93.2040208@selhorst.net> (raw)
In-Reply-To: <20080423095036.GN28933@cs181133002.pp.htv.fi>
Acked-by: Marcel Selhorst <tpm@selhorst.net>
Adrian Bunk schrieb:
> This patch makes two needlessly global structs static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 14 Apr 2008
> - 31 Mar 2008
>
> drivers/char/tpm/tpm_bios.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> 030a8d37553ae500a00cd0005c763863452b7cbc diff --git a/drivers/char/tpm/tpm_bios.c b/drivers/char/tpm/tpm_bios.c
> index 60a2d26..68f052b 100644
> --- a/drivers/char/tpm/tpm_bios.c
> +++ b/drivers/char/tpm/tpm_bios.c
> @@ -448,7 +448,7 @@ out_free:
> goto out;
> }
>
> -const struct file_operations tpm_ascii_bios_measurements_ops = {
> +static const struct file_operations tpm_ascii_bios_measurements_ops = {
> .open = tpm_ascii_bios_measurements_open,
> .read = seq_read,
> .llseek = seq_lseek,
> @@ -486,7 +486,7 @@ out_free:
> goto out;
> }
>
> -const struct file_operations tpm_binary_bios_measurements_ops = {
> +static const struct file_operations tpm_binary_bios_measurements_ops = {
> .open = tpm_binary_bios_measurements_open,
> .read = seq_read,
> .llseek = seq_lseek,
prev parent reply other threads:[~2008-04-23 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 9:50 [2.6 patch] tpm_bios.c: make 2 structs static Adrian Bunk
2008-04-23 10:12 ` Marcel Selhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480F0B93.2040208@selhorst.net \
--to=tpm@selhorst.net \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox