* [PATCH] blackbird_find_mailbox negative return ignored in blackbird_initialize_codec()
@ 2008-04-23 19:17 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2008-04-23 19:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, v4l-dvb-maintainer, video4linux-list, lkml
dev->mailbox is unsigned. so a negative return goes unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c
index a99e9d5..07abd41 100644
--- a/drivers/media/video/cx88/cx88-blackbird.c
+++ b/drivers/media/video/cx88/cx88-blackbird.c
@@ -546,10 +546,12 @@ static int blackbird_initialize_codec(struct cx8802_dev *dev)
if (retval < 0)
return retval;
- dev->mailbox = blackbird_find_mailbox(dev);
- if (dev->mailbox < 0)
+ retval = blackbird_find_mailbox(dev);
+ if (retval < 0)
return -1;
+ dev->mailbox = retval;
+
retval = blackbird_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0); /* ping */
if (retval < 0) {
dprintk(0, "ERROR: Firmware ping failed!\n");
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-23 19:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 19:17 [PATCH] blackbird_find_mailbox negative return ignored in blackbird_initialize_codec() Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox