public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe()
Date: Wed, 23 Apr 2008 22:55:36 +0200	[thread overview]
Message-ID: <480FA248.7080900@tiscali.nl> (raw)
In-Reply-To: <480F99D5.7070300@tiscali.nl>

similarly,
---
xilinx_spi->irq is unsigned, so the test fails

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
index cf6aef3..613db82 100644
--- a/drivers/spi/xilinx_spi.c
+++ b/drivers/spi/xilinx_spi.c
@@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev)
 		goto put_master;
 	}
 
-	xspi->irq = platform_get_irq(dev, 0);
-	if (xspi->irq < 0) {
-		ret = -ENXIO;
+	ret = platform_get_irq(dev, 0);
+	if (ret < 0)
 		goto unmap_io;
-	}
+
+	xspi->irq = ret;
+	ret = 0;
 
 	master->bus_num = pdata->bus_num;
 	master->num_chipselect = pdata->num_chipselect;


  parent reply	other threads:[~2008-04-23 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 20:19 [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() Roel Kluin
2008-04-23 20:39 ` Kumar Gala
2008-04-30 22:12   ` [spi-devel-general] " David Brownell
2008-04-23 20:55 ` Roel Kluin [this message]
2008-04-24  7:35   ` [PATCH 2/2 v2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480FA248.7080900@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox