From: Roel Kluin <12o3l@tiscali.nl>
To: pb@handhelds.org, sameo@openedhand.com,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] asic3: platform_get_irq() may return signed unnoticed
Date: Wed, 23 Apr 2008 23:32:53 +0200 [thread overview]
Message-ID: <480FAB05.1040107@tiscali.nl> (raw)
asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index f6f2d96..95f7b0c 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -302,7 +302,7 @@ static int asic3_irq_probe(struct platform_device *pdev)
unsigned int irq, irq_base;
asic->irq_nr = platform_get_irq(pdev, 0);
- if (asic->irq_nr < 0)
+ if (asic->irq_nr == -ENXIO)
return asic->irq_nr;
/* turn on clock to IRQ controller */
next reply other threads:[~2008-04-23 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 21:32 Roel Kluin [this message]
2008-04-23 22:38 ` [PATCH v2] asic3: platform_get_irq() may return signed unnoticed Roel Kluin
2008-04-23 22:58 ` Roel Kluin
2008-04-23 23:16 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480FAB05.1040107@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=pb@handhelds.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox