[PATCH] kconfig: fix broken target update-po-config

[PATCH] kconfig: fix broken target update-po-config

[Massimo Maiurana]

In the latest kernel "make update-po-config" fails because it tries
to open arch/Kconfig/Kconfig, since the ls command doesn't
distinguish between files and directories.

trivial patch below.

Signed-off-by: Massimo Maiurana <maiurana@gmail.com>

---
diff -u linux/scripts/kconfig/Makefile linux.new/scripts/kconfig/Makefile
--- linux/scripts/kconfig/Makefile      2008-04-17 12:51:55.000000000 +0200
+++ linux.new/scripts/kconfig/Makefile  2008-04-23 18:32:13.000000000 +0200
@@ -36,7 +36,7 @@
             --output $(obj)/config.pot
         $(Q)sed -i s/CHARSET/UTF-8/ $(obj)/config.pot
         $(Q)ln -fs Kconfig.i386 arch/um/Kconfig.arch
-       $(Q)(for i in `ls arch/`;                        \
+       $(Q)(for i in `find ./arch -maxdepth 1 -mindepth 1 -type d | cut -c 8-`; \
             do                                           \
                 echo "  GEN $$i";                        \
                 $(obj)/kxgettext arch/$$i/Kconfig        \



-- 
        Massimo Maiurana         massimo<at>ragusa.linux.it
        http://massimo.solira.org       GPG keyID #7044D601

Articolo 11 - L'Italia ripudia la guerra come strumento di offesa
alla libertà degli altri popoli e come mezzo di risoluzione delle
controversie internazionali....

Re: [PATCH] kconfig: fix broken target update-po-config

[Sam Ravnborg]

On Wed, Apr 23, 2008 at 11:38:43PM +0200, Massimo Maiurana wrote:
> In the latest kernel "make update-po-config" fails because it tries
> to open arch/Kconfig/Kconfig, since the ls command doesn't
> distinguish between files and directories.
> 
> trivial patch below.

Thanks.

Your patch was MIME damaged so when looking closer at it I
decided for a simpler approach:

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 32e8c5a..fa1a7d5 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -36,10 +36,10 @@ update-po-config: $(obj)/kxgettext $(obj)/gconf.glade.h
 	    --output $(obj)/config.pot
 	$(Q)sed -i s/CHARSET/UTF-8/ $(obj)/config.pot
 	$(Q)ln -fs Kconfig.i386 arch/um/Kconfig.arch
-	$(Q)(for i in `ls arch/`;                        \
+	$(Q)(for i in `ls arch/*/Kconfig`;               \
 	    do                                           \
 		echo "  GEN $$i";                        \
-		$(obj)/kxgettext arch/$$i/Kconfig        \
+		$(obj)/kxgettext $$i                     \
 		     >> $(obj)/config.pot;               \
 	    done )
 	$(Q)msguniq --sort-by-file --to-code=UTF-8 $(obj)/config.pot \

	Sam