From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757212AbbJVKNz (ORCPT ); Thu, 22 Oct 2015 06:13:55 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59969 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757140AbbJVKNw (ORCPT ); Thu, 22 Oct 2015 06:13:52 -0400 From: Arnd Bergmann To: Eric Auger Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration Date: Thu, 22 Oct 2015 12:13:30 +0200 Message-ID: <4810974.apRDTjc3oB@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445506922-6005-4-git-send-email-eric.auger@linaro.org> References: <1445506922-6005-1-git-send-email-eric.auger@linaro.org> <1445506922-6005-4-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZJM/aaxHIvRwSnOl1AC/+ghylCXGNwx5rz5gQijzf9DV4rSM7Yg zkdbcXG2Y8sJCiKg9CkAUgaTJM785tRQI5vjAiFf58orFkoQPsb3LJGOWuTzq9K6+rKV6df u9SbE65YTZLogo1ENje3NZTgvziIFsf5kG4gf+wZ/WffF+STUqEHpO36BNCnLOuEPiPoO5L 1ZejX60n59o1lwfJB0rCw== X-UI-Out-Filterresults: notjunk:1;V01:K0:CWAgQsIbiE0=:oSxT5ypnwp+JzG94ejn5pF YVJybPN46zsV2Atn/bMBtLVTQRQEivcTv5j1FANyfo7df3rWqOWl/+QN2P/xDcyJ1V8lg4pgg cY/ENZYGSLgCxO8rra3N6021yhWKmqG8YVrNsP9HugsnzzjmnZCc12jHDMePiCcfeuQj9Qr2q nXUgJSLGHWXHmSr1nyC3LCGxMM92eFZx2bAPmNJHt7pmxLO6aw3zz7tLdF9YBZPyD6mVHEkeS BIi90G/q13csZuqw/0jSAEGUl+tdqlhaJG0vpftuDncbNAsrQGuxcjoVDekdqnhnSrFHXyTpl d7BczgrKmCA7EAjT4Ncc+XRiGXJtpvcd5uGJdetOLqAkUzssiFY1X71llvpWm8S5iZ730HBDh XoFnaDBo4FGv/50A/6ii6amJbnJ52yvA/4bcyZL+btbsx2PIlWQt/TIx8XKEIa/1M/Xof8OUK UjAMd6e1AxYIEl+uqE0Zvyj71DILWVKvmd33FfYuSubnFTW6qIb0klbROtEULn32ahxAs9bhc NI9vFSEebQx/dSxYiblu2XhXMatkshLKyImvTCBgvi5Gk6n+sn2J2NAEffwVjdxrssXY1+0uF oAXzhR7+Cxy4s0S8mTBJbukREu6bqRTIDQSp+iC0qXYadqdABNiCIgjhOcf6hEaMM+Oc8WOlm dnVbKEgTiEJXSrnKYOoxT42k96m33HW6jPXBr65lN6VSmCNKV5wB+HCiWZRIJIVGVO/w7mpo6 V3/GxGuVZb49hCRL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 22 October 2015 11:41:59 Eric Auger wrote: > This patch adds the reset function registration/unregistration. > > Signed-off-by: Eric Auger Looks good, except one thing: > @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) > return -ENOMEM; > } > > + pr_info("VFIO reset of %s\n", vdev->name); > + > /* disable IRQ */ > writel(0, reg.ioaddr + XGMAC_DMA_INTR_ENA); > This probably slipped in from debugging, please remove it. Arnd