public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
	David Miller <davem@davemloft.net>,
	alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] alternative to sys_indirect, part 1
Date: Thu, 24 Apr 2008 09:52:51 -0700	[thread overview]
Message-ID: <4810BAE3.5070406@redhat.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0804240921460.2779@woody.linux-foundation.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Linus Torvalds wrote:
> So while I don't dislike the indirect system call, I do think that if we 
> can handle a large case of the problems with an added flag to already 
> existing system calls,

The easy, clean cases I already handled back when.  I wouldn't have
implemented socket this way to preserve the function signature but
that's just me.  It's hopefully over now.

What remains isn't that easy to fix.  We need syscall interface changes.
 Yes, I'd like to avoid them, too.  But sometimes the existing
interfaces are just wrong and now we have to make a decision: new
syscalls or sys_indirect.  No way around it.

As far as the userlevel interface is concerned, this is not quite the
same.  As explained before, I've anticipated some of the problems.
signalfd, eventfd have no flags parameter in the syscall but I have them
in the userlevel interface.  I.e., any kernel change will be hidden.  At
least as far as the interface signature is concerned.


So, the question still is on the table: do you want sys_indirect?

If yes, then then new sys_accept would use sys_indirect instead of a new
entry point.  If you don't want sys_indirect, then I'll submit a new
sys_accept syscall (already have the patch here ready to go).

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFIELrj2ijCOnn/RHQRAtewAJ4+826rxwtckEvvOaXdiNSr/5ECPACfWwTn
hgt5EYrrj/imBloPE7DxHJA=
=T6LW
-----END PGP SIGNATURE-----

  reply	other threads:[~2008-04-24 16:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24  4:03 [PATCH] alternative to sys_indirect, part 1 Ulrich Drepper
2008-04-24 10:25 ` Alan Cox
2008-04-24 12:34   ` Michael Kerrisk
2008-04-24 14:49     ` Ulrich Drepper
2008-04-24 14:42       ` Alan Cox
2008-04-24 15:19         ` Ulrich Drepper
2008-04-24 15:05       ` Michael Kerrisk
2008-04-24 14:18   ` Ulrich Drepper
2008-04-24 14:24     ` Alan Cox
2008-04-24 15:16       ` Ulrich Drepper
2008-04-24 15:03         ` Alan Cox
2008-04-24 15:44           ` Jakub Jelinek
2008-04-24 15:24             ` Alan Cox
2008-04-24 16:00               ` David Miller
2008-04-24 15:38                 ` Alan Cox
2008-04-24 16:09                   ` David Miller
2008-04-24 16:45                   ` Michael Kerrisk
2008-04-26 22:41                     ` dean gaudet
2008-04-24 15:45           ` Ulrich Drepper
2008-04-24 15:27             ` Alan Cox
2008-04-24 16:04               ` Ulrich Drepper
2008-04-24 15:45                 ` Alan Cox
2008-04-24 16:06           ` Michael Kerrisk
2008-04-24 16:49     ` Evgeniy Polyakov
2008-04-24 15:29   ` Linus Torvalds
2008-04-24 15:39     ` David Miller
2008-04-24 16:03       ` Michael Kerrisk
2008-04-24 15:42         ` Alan Cox
2008-04-24 16:48           ` Michael Kerrisk
2008-04-24 17:20             ` H. Peter Anvin
2008-04-24 17:31               ` Ulrich Drepper
2008-04-24 17:34                 ` H. Peter Anvin
2008-04-24 16:30         ` Linus Torvalds
2008-04-24 16:52           ` Ulrich Drepper [this message]
2008-04-24 12:27 ` Michael Kerrisk
2008-04-24 12:46   ` David Collier-Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4810BAE3.5070406@redhat.com \
    --to=drepper@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox