public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Chris Peterson <cpeterso@cpeterso.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c
Date: Sun, 27 Apr 2008 09:42:19 +0200	[thread overview]
Message-ID: <48142E5B.3000109@gmail.com> (raw)
In-Reply-To: <a24804730804270009x3398a190wf68e52280015fc7f@mail.gmail.com>

On 04/27/2008 09:09 AM, Chris Peterson wrote:
> This patch against linux-2.6.25-git7.
> 
> chris
> 
> 
> Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> ---
> diff -Naur linux-2.6.25-git7/drivers/char/ip2/i2ellis.c
> linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c
> --- linux-2.6.25-git7/drivers/char/ip2/i2ellis.c	2008-04-25
> 22:47:01.000000000 -0700
> +++ linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c	2008-04-25
> 23:19:57.000000000 -0700
> @@ -86,22 +86,6 @@
>  }
> 
>  //******************************************************************************
> -// Function:   iiEllisCleanup()
> -// Parameters: None
> -//
> -// Returns:    Nothing
> -//
> -// Description:
> -//
> -// This routine performs any required cleanup of the iiEllis subsystem.
> -//
> -//******************************************************************************
> -static void
> -iiEllisCleanup(void)
> -{
> -}

Well, have you tried to even build it? The .c file is *included* into i2main.c 
where this function is used.

NAK

  reply	other threads:[~2008-04-27  7:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27  7:09 [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c Chris Peterson
2008-04-27  7:42 ` Jiri Slaby [this message]
2008-04-28  1:51   ` Chris Peterson
2008-04-28  7:41     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48142E5B.3000109@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=cpeterso@cpeterso.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox