From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Miller <davem@davemloft.net>,
James.Bottomley@HansenPartnership.com, mingo@elte.hu,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [patch] x86, voyager: fix ioremap_nocache()
Date: Sun, 27 Apr 2008 15:56:58 -0700 [thread overview]
Message-ID: <481504BA.4090402@zytor.com> (raw)
In-Reply-To: <481503ED.8060107@garzik.org>
Jeff Garzik wrote:
>
> Understood.
>
> I guess I am more annoyed that this stealth semantics change appears to
> have broken everything that depends on pci_iomap(), including 90%+ of
> all libata drivers, unless I am missing something.
>
> That one piece of code (pci_iomap) was correct under the old semantics,
> on x86 and elsewhere. It's tested and working nicely, and depended upon
> by many drivers.
>
That one piece of code has had no effective change. Under both the old
and the new code, both branches functionally because ioremap_nocache(),
in one case because of MTRR and in one case because of PAT.
-hpa
next prev parent reply other threads:[~2008-04-27 22:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 20:51 Breakage caused by unreviewed patch in x86 tree James Bottomley
2008-04-27 20:53 ` David Miller
2008-04-27 21:48 ` [patch] x86, voyager: fix ioremap_nocache() Ingo Molnar
2008-04-27 22:05 ` James Bottomley
2008-04-27 22:36 ` Willy Tarreau
2008-04-27 22:41 ` Ingo Molnar
2008-04-27 23:18 ` Ingo Molnar
2008-04-27 23:31 ` David Miller
2008-04-28 0:31 ` Rik van Riel
2008-04-28 0:45 ` Al Viro
2008-04-28 0:52 ` H. Peter Anvin
2008-04-28 9:01 ` Alan Cox
2008-04-28 9:17 ` David Miller
2008-04-28 9:48 ` Adrian Bunk
2008-04-28 11:50 ` Ingo Molnar
2008-04-28 6:10 ` Christoph Hellwig
2008-04-28 16:55 ` H. Peter Anvin
2008-04-27 22:34 ` James Bottomley
2008-04-27 22:39 ` Jeff Garzik
2008-04-27 22:44 ` H. Peter Anvin
2008-04-27 22:46 ` David Miller
2008-04-27 22:52 ` H. Peter Anvin
2008-04-27 22:58 ` David Miller
2008-04-27 23:04 ` H. Peter Anvin
2008-04-30 20:35 ` Eric W. Biederman
2008-04-27 23:34 ` Jeff Garzik
2008-04-27 23:39 ` H. Peter Anvin
2008-04-27 22:53 ` Jeff Garzik
2008-04-27 22:56 ` H. Peter Anvin [this message]
2008-04-27 22:59 ` David Miller
2008-04-27 23:02 ` Jeff Garzik
2008-04-27 23:14 ` Arjan van de Ven
2008-04-27 23:01 ` Arjan van de Ven
2008-04-30 21:44 ` James Bottomley
2008-04-30 22:39 ` H. Peter Anvin
2008-04-27 23:01 ` Thomas Gleixner
2008-04-28 14:10 ` Arjan van de Ven
2008-04-28 14:29 ` James Bottomley
2008-04-28 15:07 ` Arjan van de Ven
2008-04-28 19:59 ` H. Peter Anvin
2008-04-27 22:00 ` Breakage caused by unreviewed patch in x86 tree H. Peter Anvin
2008-04-27 22:10 ` James Bottomley
2008-04-27 22:13 ` H. Peter Anvin
2008-04-27 22:18 ` James Bottomley
2008-04-27 22:31 ` H. Peter Anvin
2008-04-27 22:58 ` Arjan van de Ven
2008-04-27 23:00 ` David Miller
2008-04-27 23:07 ` Arjan van de Ven
2008-04-27 23:03 ` James Bottomley
2008-04-27 23:11 ` Arjan van de Ven
2008-04-27 23:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481504BA.4090402@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).