* [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c
@ 2008-04-27 7:09 Chris Peterson
2008-04-27 7:42 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Chris Peterson @ 2008-04-27 7:09 UTC (permalink / raw)
To: linux-kernel
This patch against linux-2.6.25-git7.
chris
Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
---
diff -Naur linux-2.6.25-git7/drivers/char/ip2/i2ellis.c
linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c
--- linux-2.6.25-git7/drivers/char/ip2/i2ellis.c 2008-04-25
22:47:01.000000000 -0700
+++ linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c 2008-04-25
23:19:57.000000000 -0700
@@ -86,22 +86,6 @@
}
//******************************************************************************
-// Function: iiEllisCleanup()
-// Parameters: None
-//
-// Returns: Nothing
-//
-// Description:
-//
-// This routine performs any required cleanup of the iiEllis subsystem.
-//
-//******************************************************************************
-static void
-iiEllisCleanup(void)
-{
-}
-
-//******************************************************************************
// Function: iiSetAddress(pB, address, delay)
// Parameters: pB - pointer to the board structure
// address - the purported I/O address of the board
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c
2008-04-27 7:09 [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c Chris Peterson
@ 2008-04-27 7:42 ` Jiri Slaby
2008-04-28 1:51 ` Chris Peterson
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2008-04-27 7:42 UTC (permalink / raw)
To: Chris Peterson; +Cc: linux-kernel
On 04/27/2008 09:09 AM, Chris Peterson wrote:
> This patch against linux-2.6.25-git7.
>
> chris
>
>
> Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> ---
> diff -Naur linux-2.6.25-git7/drivers/char/ip2/i2ellis.c
> linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c
> --- linux-2.6.25-git7/drivers/char/ip2/i2ellis.c 2008-04-25
> 22:47:01.000000000 -0700
> +++ linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c 2008-04-25
> 23:19:57.000000000 -0700
> @@ -86,22 +86,6 @@
> }
>
> //******************************************************************************
> -// Function: iiEllisCleanup()
> -// Parameters: None
> -//
> -// Returns: Nothing
> -//
> -// Description:
> -//
> -// This routine performs any required cleanup of the iiEllis subsystem.
> -//
> -//******************************************************************************
> -static void
> -iiEllisCleanup(void)
> -{
> -}
Well, have you tried to even build it? The .c file is *included* into i2main.c
where this function is used.
NAK
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c
2008-04-27 7:42 ` Jiri Slaby
@ 2008-04-28 1:51 ` Chris Peterson
2008-04-28 7:41 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Chris Peterson @ 2008-04-28 1:51 UTC (permalink / raw)
To: Jiri Slaby; +Cc: linux-kernel
Yes, I did compile it, but I now realize I had compiled the computone
driver to be linked statically, but iiEllisCleanup() is only called
when the driver is built as a module. What is the appropriate cleanup
code path for non-modular drivers?
chris
On Sun, Apr 27, 2008 at 12:42 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 04/27/2008 09:09 AM, Chris Peterson wrote:
>
> > This patch against linux-2.6.25-git7.
> >
> > chris
> >
> >
> > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > ---
> > diff -Naur linux-2.6.25-git7/drivers/char/ip2/i2ellis.c
> > linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c
> > --- linux-2.6.25-git7/drivers/char/ip2/i2ellis.c 2008-04-25
> > 22:47:01.000000000 -0700
> > +++ linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c 2008-04-25
> > 23:19:57.000000000 -0700
> > @@ -86,22 +86,6 @@
> > }
> >
> >
> //******************************************************************************
> > -// Function: iiEllisCleanup()
> > -// Parameters: None
> > -//
> > -// Returns: Nothing
> > -//
> > -// Description:
> > -//
> > -// This routine performs any required cleanup of the iiEllis subsystem.
> > -//
> >
> -//******************************************************************************
> > -static void
> > -iiEllisCleanup(void)
> > -{
> > -}
> >
>
> Well, have you tried to even build it? The .c file is *included* into
> i2main.c where this function is used.
>
> NAK
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c
2008-04-28 1:51 ` Chris Peterson
@ 2008-04-28 7:41 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2008-04-28 7:41 UTC (permalink / raw)
To: Chris Peterson; +Cc: linux-kernel
On 04/28/2008 03:51 AM, Chris Peterson wrote:
> Yes, I did compile it, but I now realize I had compiled the computone
> driver to be linked statically, but iiEllisCleanup() is only called
> when the driver is built as a module. What is the appropriate cleanup
> code path for non-modular drivers?
Remove the function and all its references.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-28 7:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-27 7:09 [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c Chris Peterson
2008-04-27 7:42 ` Jiri Slaby
2008-04-28 1:51 ` Chris Peterson
2008-04-28 7:41 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox