From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754446AbbI3IP7 (ORCPT ); Wed, 30 Sep 2015 04:15:59 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:53131 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbbI3IPy (ORCPT ); Wed, 30 Sep 2015 04:15:54 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Felipe Balbi , Tony Lindgren , daniel.lezcano@linaro.org, Linux Kernel Mailing List , tglx@linutronix.de, Linux OMAP Mailing List Subject: Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Date: Wed, 30 Sep 2015 10:15:25 +0200 Message-ID: <4815825.NCBBBMgLGf@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1443559446-26969-12-git-send-email-balbi@ti.com> References: <1443559446-26969-1-git-send-email-balbi@ti.com> <1443559446-26969-12-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DtSFAgkVLWsZjiotnrGBqKhkkUl3nmdj1dvcZtV0pn1w76LmqW0 N9HPHQD34GZ7C3lpeG6lXKQbZ0YJr74vQp3rUqDAuCEFygWNUgXcy05OrHp4iG8O4m6NliX 2eQx85g68rOvtYYy6BXTyl/BXQicqxWpDJduo60NzIFFC1Xjj1QTt42uscWldo1O8SXnZgn IhQvpONoTl2ZRRDtd+yJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nIB10VA1yZ4=:ONr2IBO25e3P+PHQu9kFws obrDadyS6Z8wNL0rdG29KcoDtxgaHHPYjNZk2jmOWH9EYy3vKAPhwy8rJ7NseSs5FUy/gmXCX g9co2B5zPUTZqYgSjgzdkkP3zX5P3fxPN6LB03ilqhIy677TsTWAnpnjUAs+pTm/eL4FHnbQJ N5D8HPRE6fkV1w8SGEI8+GgZFNbEUrGHU6HttrKb07gRJCHy9neqo6mDIloDjpExkUfuSVtjf V2PYLLg68SHBbUFCzIjaTCg6LvuECXsEigXvmFm3kBh3f2t+d/jTstEbD3idLZfJNGhXQ57Gi EWrttsgT84Iiqye3R8ediuM1tpw5M8gshQWHg6BlQAt4DGRlJN8Fg41iMNndMKW57ZWM4JVxW sh68/cnD3fklH41ejWC2qp7PTetPyQvrBXC24gf+4a6gYxtWUy3eB965QRVnWXq9zeP3EiVDJ tXbOGIA67RMhBXhISlkeFYyJbh8vC1xc7aXlSpPWEtuee73oZkAe/fCdCGFMEroI2cbu3FxLm XNPgtHyDNTP/cp4kd9M/dv21tfa6HjDZd6x6w7IG9VR7EBIXW5Q02F5qV9oqzXJsukbAffsSL D27Fh9CiSRUYFnLWD9e5kYXm+IF0YuyUn6G7TFLqVS5SOjdXeAkrY+M8SYjBe5ftC+COHGcIa mthqh7O6TP/EP2cFGJGFVw1QJCxr+T6r4XYV7T7Wf+2B+ZalhzsQMVDCCAseRU8YWvwt3Hs9o 2/KCHIj/skfUfQrs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 29 September 2015 15:44:06 Felipe Balbi wrote: > All devices should have a default status. Ignoring > the arguments if it should be 'okay' or 'disabled' > by default, let's set them all the 'disabled' and > have boards enable 32k counter. > > Signed-off-by: Felipe Balbi > The patch looks good, but the description is slightly incorrect: There is no reason to list "status='okay'" other than overriding the 'disabled' status. I'd phrase it something like: "We want the use of the 32k counter to be a per-board setting, so let's disable it by default in each dtsi file and override the setting in the boards. Any board that does not wire up the counter should leave it disabled". However, if you really want all boards to provide the counter all the time, I'd argue that we're better off dropping this patch. We use the status="disabled" trick for anything that may or may not be working based on the board design, but things that are present everywhere don't need this. Arnd