public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: nscott@aconex.com
Cc: Christoph Hellwig <hch@infradead.org>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	David Chinner <dgc@sgi.com>,
	xfs@oss.sgi.com, Eric Sandeen <sandeen@sandeen.net>,
	Adrian Bunk <bunk@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
Date: Mon, 28 Apr 2008 12:32:05 +0200	[thread overview]
Message-ID: <4815A7A5.9040507@firstfloor.org> (raw)
In-Reply-To: <1209341212.23166.122.camel@edge.scott.net.au>


> Having to compile chunks of XFS code in both kernel and
> userspace is also wierd (relative to other drivers),

Perhaps it would be a good idea to mark the files where that is expected
to work clearly.

> and
> its a side-effect of needing to do that (all the code
> dealing with specifics of ondisk format is shared).

But does that really need "STATIC"? Seems doubtful to me.

-Andi


  parent reply	other threads:[~2008-04-28 10:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@googlemail.com>
2008-04-26 20:02 ` [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() Andi Kleen
2008-04-26 20:07   ` Christoph Hellwig
2008-04-26 20:26     ` Andi Kleen
2008-04-26 20:23       ` Christoph Hellwig
2008-04-28  0:06         ` Nathan Scott
2008-04-28  5:56           ` Christoph Hellwig
2008-04-28 10:32           ` Andi Kleen [this message]
2008-04-28 23:52             ` Nathan Scott
2008-04-26 14:51 Denys Vlasenko
2008-04-26 18:54 ` Eric Sandeen
2008-04-26 23:05   ` Denys Vlasenko
2008-04-26 20:03 ` Christoph Hellwig
2008-04-26 23:45   ` Denys Vlasenko
2008-04-27 23:40 ` David Chinner
2008-04-27 23:57   ` Denys Vlasenko
2008-04-28  3:32   ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4815A7A5.9040507@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=bunk@kernel.org \
    --cc=dgc@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nscott@aconex.com \
    --cc=sandeen@sandeen.net \
    --cc=vda.linux@googlemail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox