From: Avi Kivity <avi@qumranet.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Izik Eidus <izike@qumranet.com>,
kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: kvm: how big is type?
Date: Mon, 28 Apr 2008 14:44:11 +0300 [thread overview]
Message-ID: <4815B88B.3010909@qumranet.com> (raw)
In-Reply-To: <1209323919.14173.73.camel@brick>
Harvey Harrison wrote:
> arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant value (100 becomes 0)
> arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant value (100 becomes 0)
>
> The problem:
> cseg_desc.type &= ~(1 << 8); //clear the B flag
> nseg_desc.type |= (1 << 8);
>
> type is a 4-bit bitfield on x86....please look into this.
>
>
I think it ought to be (1 << 1), not (1 << 8), as it refers to the
"busy" bit of the task type. Izik?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-04-28 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 19:18 kvm: how big is type? Harvey Harrison
2008-04-28 11:44 ` Avi Kivity [this message]
2008-04-28 15:23 ` Izik Eidus
2008-04-28 16:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4815B88B.3010909@qumranet.com \
--to=avi@qumranet.com \
--cc=harvey.harrison@gmail.com \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).