Re: [PATCH] build fix for smp

Sergio Luis
2008-04-28T09:01:45Z

On Mon, Apr 28, 2008 at 5:50 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Sergio Luis <sergio@uece.br> wrote:
>
> > Hello, what's the final fix for this issue? 2.6.25-git11 is still
> > broken, just gave me
>
> > arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
> > smp.c:(.text+0xc751): undefined reference to `reboot_force'
> > make: *** [.tmp_vmlinux1] Error 1
>
> > for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39
>
> btw., that's a VISWS config - that wont boot on any PC. The patch below
> should fix this.

Yep, it does fix it thanks.
-sergio

>
> Ingo
>
> --------------------------->
> Subject: x86 VISWS: build fix
> From: Ingo Molnar <mingo@elte.hu>
> Date: Mon Apr 28 10:46:58 CEST 2008
>
> the 'reboot_force' flag is a notion that non-PC subarchitectures do
> not have.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> include/asm-x86/proto.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> Index: linux/include/asm-x86/proto.h
> ===================================================================
> --- linux.orig/include/asm-x86/proto.h
> +++ linux/include/asm-x86/proto.h
> @@ -20,7 +20,11 @@ extern void syscall32_cpu_init(void);
>
> extern void check_efer(void);
>
> +#ifdef X86_BIOS_REBOOT
> extern int reboot_force;
> +#else
> +static const int reboot_force = 0;
> +#endif
>
> long do_arch_prctl(struct task_struct *task, int code, unsigned long addr);
>
>