Re: [PATCH] build fix for smp

Glauber Costa
2008-04-28T14:25:48Z

Sergio Luis wrote:
> On Wed, Mar 19, 2008 at 4:52 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> * Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
>>
>> > +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_BIOS_REBOOT)
>> > if (reboot_force)
>> > return;
>> > +#endif
>>
>> please solve it slightly differently: introduce a uniformly usable
>> reboot_force flag, that will always default to the constant of 1 if
>> !X86_64 && !X86_BIOS_REBOOT. That makes the code cleaner - and not the
>> least i can also merge the fix earlier in the series, without having to
>> redo the big smp.c movement patch :-)
>>
>> Ingo
>>
>
> Hello,
> what's the final fix for this issue? 2.6.25-git11 is still broken, just gave me
Doh. I had the patch, but completely forgot to send it to ingo. Thanks
for raising this issue again. (But I saw ingo already put a fix for this in)

> arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
> smp.c:(.text+0xc751): undefined reference to `reboot_force'
> make: *** [.tmp_vmlinux1] Error 1
>
> for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39
>
> thanks,
> -sergio