From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936314AbYD1QKk (ORCPT ); Mon, 28 Apr 2008 12:10:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934092AbYD1QKb (ORCPT ); Mon, 28 Apr 2008 12:10:31 -0400 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:34252 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933630AbYD1QKa (ORCPT ); Mon, 28 Apr 2008 12:10:30 -0400 Message-ID: <4815F6F4.2080806@qumranet.com> Date: Mon, 28 Apr 2008 19:10:28 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Izik Eidus CC: Harvey Harrison , LKML , kvm-devel Subject: Re: kvm: how big is type? References: <1209323919.14173.73.camel@brick> <4815B88B.3010909@qumranet.com> <4815EC08.9000206@qumranet.com> In-Reply-To: <4815EC08.9000206@qumranet.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Izik Eidus wrote: > Avi Kivity wrote: > >> Harvey Harrison wrote: >> >>> arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant >>> value (100 becomes 0) >>> arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant >>> value (100 becomes 0) >>> >>> The problem: >>> cseg_desc.type &= ~(1 << 8); //clear the B flag >>> nseg_desc.type |= (1 << 8); >>> >>> type is a 4-bit bitfield on x86....please look into this. >>> >>> >>> >> I think it ought to be (1 << 1), not (1 << 8), as it refers to the >> "busy" bit of the task type. Izik? >> >> >> > From cf6e76c69a38a983df0c84a3dcc2336042eb3436 Mon Sep 17 00:00:00 2001 > From: Izik Eidus > Date: Mon, 28 Apr 2008 18:16:08 +0300 > Subject: [PATCH] KVM: x86: task switch: fix wrong bit setting for the busy flag. > the busy bit is in offset of 1 inside type and not in 8. > Applied, thanks. -- error compiling committee.c: too many arguments to function